From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F8B4C3A59F for ; Thu, 29 Aug 2019 15:52:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 524DE205ED for ; Thu, 29 Aug 2019 15:52:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728819AbfH2PwY (ORCPT ); Thu, 29 Aug 2019 11:52:24 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:3958 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728374AbfH2PwT (ORCPT ); Thu, 29 Aug 2019 11:52:19 -0400 Received: from DGGEMM406-HUB.china.huawei.com (unknown [172.30.72.55]) by Forcepoint Email with ESMTP id 0C6C9E086C35E691A811; Thu, 29 Aug 2019 23:52:15 +0800 (CST) Received: from dggeme762-chm.china.huawei.com (10.3.19.108) by DGGEMM406-HUB.china.huawei.com (10.3.20.214) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 29 Aug 2019 23:52:14 +0800 Received: from architecture4 (10.140.130.215) by dggeme762-chm.china.huawei.com (10.3.19.108) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10; Thu, 29 Aug 2019 23:52:14 +0800 Date: Thu, 29 Aug 2019 23:51:27 +0800 From: Gao Xiang To: Dan Carpenter CC: , Sasha Levin , Valdis =?gbk?Q?Kl=A8=A5tnieks?= , Greg Kroah-Hartman , , "Christoph Hellwig" , , OGAWA Hirofumi Subject: Re: [PATCH] staging: exfat: add exfat filesystem code to staging Message-ID: <20190829155127.GA136563@architecture4> References: <20190828170022.GA7873@kroah.com> <20190829062340.GB3047@infradead.org> <20190829063955.GA30193@kroah.com> <20190829094136.GA28643@infradead.org> <20190829095019.GA13557@kroah.com> <20190829103749.GA13661@infradead.org> <20190829111810.GA23393@kroah.com> <20190829151144.GJ23584@kadam> <20190829152757.GA125003@architecture4> <20190829154346.GK23584@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20190829154346.GK23584@kadam> User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [10.140.130.215] X-ClientProxiedBy: dggeme703-chm.china.huawei.com (10.1.199.99) To dggeme762-chm.china.huawei.com (10.3.19.108) X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dan, On Thu, Aug 29, 2019 at 06:43:46PM +0300, Dan Carpenter wrote: > > p.s. There are 2947 (un)likely places in fs/ directory. > > I was complaining about you adding new pointless ones, not existing > ones. The likely/unlikely annotations are supposed to be functional and > not decorative. I explained this very clearly. I don't think that is mostly pointless. I think it has functional use because all error handling paths are rarely happened, or can you remove the unlikely in IS_ERR as well? > > Probably most of the annotations in fs/ are wrong but they are also > harmless except for the slight messiness. However there are definitely > some which are important so removing them all isn't a good idea. > > > If you like, I will delete them all. > > But for erofs, I don't think that any of the likely/unlikely calls have > been thought about so I'm fine with removing all of them in one go. Maybe some misuse but rare, I will show you case by case. Wait a minute. Thanks, Gao Xiang > > regards, > dan carpenter >