From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Bandan Das <bsd@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
"H. Peter Anvin" <hpa@zytor.com>,
Peter Zijlstra <peterz@infradead.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: Fixes tag needs some work in the tip tree
Date: Thu, 29 Aug 2019 19:18:00 +1000 [thread overview]
Message-ID: <20190829191800.28cd34c2@canb.auug.org.au> (raw)
In-Reply-To: <jpgwoewnzra.fsf@linux.bootlegged.copy>
[-- Attachment #1: Type: text/plain, Size: 1816 bytes --]
Hi Bandan,
On Thu, 29 Aug 2019 04:26:33 -0400 Bandan Das <bsd@redhat.com> wrote:
>
> Stephen Rothwell <sfr@canb.auug.org.au> writes:
>
> > In commit
> >
> > bae3a8d3308e ("x86/apic: Do not initialize LDR and DFR for bigsmp")
> >
> > Fixes tag
> >
> > Fixes: db7b9e9f26b8 ("[PATCH] Clustered APIC setup for >8 CPU systems")
> >
> > has these problem(s):
> >
> > - Target SHA1 does not exist
> >
>
> I tried to dig this up and I believe that this is from pre-git.
> I went back as far as commit 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2
> Author: Linus Torvalds <torvalds@ppc970.osdl.org>
> Date: Sat Apr 16 15:20:36 2005 -0700
>
> Linux-2.6.12-rc2
>
> Initial git repository build. I'm not bothering with the full history,
> even though we have it. We can create a separate "historical" git
> archive of that later if we want to, and in the meantime it's about
> 3.2GB when imported into git - space that would just make the early
> git days unnecessarily complicated, when we don't have a lot of good
> infrastructure for it.
>
> Let it rip!
>
> which adds init_apic_ldr() in include/asm-i386/mach-bigsmp/mach_apic.h with
> the following:
>
> +static inline void init_apic_ldr(void)
> +{
> + unsigned long val;
> +
> + apic_write_around(APIC_DFR, APIC_DFR_VALUE);
> + val = apic_read(APIC_LDR) & ~APIC_LDR_MASK;
> + val = calculate_ldr(val);
> + apic_write_around(APIC_LDR, val);
> +}
> ...
>
>
> So, the bug seems to be present here as well...
Ah ha!
commit db7b9e9f26b8 ("[PATCH] Clustered APIC setup for >8 CPU systems")
is from Thomas' history git tree ... I should have read more of the
commit message :-( Sorry for the noise.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-08-29 9:18 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 22:06 linux-next: Fixes tag needs some work in the tip tree Stephen Rothwell
2019-08-29 8:26 ` Bandan Das
2019-08-29 9:18 ` Stephen Rothwell [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-03-14 21:09 Stephen Rothwell
2024-03-15 14:29 ` Thomas Gleixner
2024-02-27 21:03 Stephen Rothwell
2022-05-22 0:46 Stephen Rothwell
2022-05-12 10:49 Stephen Rothwell
2022-04-09 5:23 Stephen Rothwell
2021-12-16 18:49 Stephen Rothwell
2021-11-25 21:17 Stephen Rothwell
2021-06-24 11:16 Stephen Rothwell
2021-05-20 11:50 Stephen Rothwell
2021-05-08 2:18 Stephen Rothwell
2021-05-08 10:02 ` Song Bao Hua (Barry Song)
2021-03-28 21:30 Stephen Rothwell
2021-03-28 22:56 ` Masami Hiramatsu
2021-03-01 20:28 Stephen Rothwell
2020-11-22 10:06 Stephen Rothwell
2020-11-08 21:43 Stephen Rothwell
2020-10-28 10:19 Stephen Rothwell
2020-09-30 12:53 Stephen Rothwell
2020-09-30 12:52 Stephen Rothwell
2020-08-20 6:12 Stephen Rothwell
2020-08-20 8:21 ` Borislav Petkov
2020-08-20 9:15 ` Stephen Rothwell
2020-08-20 9:20 ` Borislav Petkov
2020-08-20 9:22 ` David Sterba
2020-08-20 9:26 ` Borislav Petkov
2020-03-24 20:44 Stephen Rothwell
2019-08-25 13:31 Stephen Rothwell
2019-06-22 14:06 Stephen Rothwell
2019-05-03 10:22 Stephen Rothwell
2019-04-25 21:09 Stephen Rothwell
2019-02-10 20:36 Stephen Rothwell
2019-02-11 7:17 ` Ingo Molnar
2019-01-17 22:35 Stephen Rothwell
2019-01-17 23:19 ` Thomas Gleixner
2019-01-17 22:31 Stephen Rothwell
2019-01-17 23:45 ` Thomas Gleixner
2019-01-18 0:32 ` Stephen Rothwell
2019-01-18 1:19 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190829191800.28cd34c2@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=bsd@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).