From: Joerg Roedel <jroedel@suse.de>
To: Eric Dumazet <edumazet@google.com>, Robin Murphy <robin.murphy@arm.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
iommu@lists.linux-foundation.org,
Eric Dumazet <eric.dumazet@gmail.com>,
Jinyu Qi <jinyuqi@huawei.com>
Subject: Re: [PATCH] iommu/iova: avoid false sharing on fq_timer_on
Date: Fri, 30 Aug 2019 12:49:25 +0200 [thread overview]
Message-ID: <20190830104925.GI17192@suse.de> (raw)
In-Reply-To: <20190828131338.89832-1-edumazet@google.com>
Looks good to me, but adding Robin for his opinion.
On Wed, Aug 28, 2019 at 06:13:38AM -0700, Eric Dumazet wrote:
> In commit 14bd9a607f90 ("iommu/iova: Separate atomic variables
> to improve performance") Jinyu Qi identified that the atomic_cmpxchg()
> in queue_iova() was causing a performance loss and moved critical fields
> so that the false sharing would not impact them.
>
> However, avoiding the false sharing in the first place seems easy.
> We should attempt the atomic_cmpxchg() no more than 100 times
> per second. Adding an atomic_read() will keep the cache
> line mostly shared.
>
> This false sharing came with commit 9a005a800ae8
> ("iommu/iova: Add flush timer").
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Jinyu Qi <jinyuqi@huawei.com>
> Cc: Joerg Roedel <jroedel@suse.de>
> ---
> drivers/iommu/iova.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/iova.c b/drivers/iommu/iova.c
> index 3e1a8a6755723a927a7942a7429ab7e6c19a0027..41c605b0058f9615c2dbdd83f1de2404a9b1d255 100644
> --- a/drivers/iommu/iova.c
> +++ b/drivers/iommu/iova.c
> @@ -577,7 +577,9 @@ void queue_iova(struct iova_domain *iovad,
>
> spin_unlock_irqrestore(&fq->lock, flags);
>
> - if (atomic_cmpxchg(&iovad->fq_timer_on, 0, 1) == 0)
> + /* Avoid false sharing as much as possible. */
> + if (!atomic_read(&iovad->fq_timer_on) &&
> + !atomic_cmpxchg(&iovad->fq_timer_on, 0, 1))
> mod_timer(&iovad->fq_timer,
> jiffies + msecs_to_jiffies(IOVA_FQ_TIMEOUT));
> }
> --
> 2.23.0.187.g17f5b7556c-goog
next prev parent reply other threads:[~2019-08-30 10:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 13:13 [PATCH] iommu/iova: avoid false sharing on fq_timer_on Eric Dumazet
2019-08-30 10:49 ` Joerg Roedel [this message]
2019-08-30 12:27 ` Robin Murphy
2019-08-30 13:22 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190830104925.GI17192@suse.de \
--to=jroedel@suse.de \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jinyuqi@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).