From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2794AC3A5A4 for ; Fri, 30 Aug 2019 11:31:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EE0642186A for ; Fri, 30 Aug 2019 11:31:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="LpaGfx4N" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727681AbfH3Lbb (ORCPT ); Fri, 30 Aug 2019 07:31:31 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:55752 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727170AbfH3Lba (ORCPT ); Fri, 30 Aug 2019 07:31:30 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x7UBSsfh121102; Fri, 30 Aug 2019 11:31:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2019-08-05; bh=MXQpf7u6DFSQNCxl5IHEXZn/5OVokPF0N7A//Laqfbw=; b=LpaGfx4NaQDz2XRxK++uChttGyGz/XEwB5wkXXnSpyfGOJwYACnzke3qDuXFh/Y4rAbc jR8sRMQmqS8MMUY7UAJXfAxF3xmclOGRXjyzqLUZKjOjNw1awSJPU75nwff06DkvMaWV ll9oK8dNGPtLG1XXpnZ3i68qiPIHxDEAX0NLMd9YiGmzJFTgHeD7FrbXPeqAmvrRtWkW 9izG10MNteHfh4KTsHGFGIZqD3woOUSmSkxEOhP7IsXoK7nKS2zjeKWPx+tgtYN6lo7i lakGsdEyEf2YAZcNAkSwNMjhWb/CzM+rS+tvYqMd7/X8/QpnNolx1sH0BgA8SwPVz+fT OQ== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by aserp2120.oracle.com with ESMTP id 2uq2wm00vy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 30 Aug 2019 11:31:07 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x7UBSqlN057236; Fri, 30 Aug 2019 11:31:07 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserp3030.oracle.com with ESMTP id 2uphav2fq9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 30 Aug 2019 11:31:06 +0000 Received: from abhmp0001.oracle.com (abhmp0001.oracle.com [141.146.116.7]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x7UBUx1t024903; Fri, 30 Aug 2019 11:31:00 GMT Received: from kadam (/41.57.98.10) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 30 Aug 2019 04:30:58 -0700 Date: Fri, 30 Aug 2019 14:30:47 +0300 From: Dan Carpenter To: Gao Xiang Cc: Chao Yu , Christoph Hellwig , Joe Perches , Greg Kroah-Hartman , devel@driverdev.osuosl.org, LKML , linux-erofs@lists.ozlabs.org, Chao Yu , Miao Xie , weidu.du@huawei.com, Fang Wei Subject: Re: [PATCH v3 6/7] erofs: remove all likely/unlikely annotations Message-ID: <20190830113047.GG8372@kadam> References: <20190830032006.GA20217@architecture4> <20190830033643.51019-1-gaoxiang25@huawei.com> <20190830033643.51019-6-gaoxiang25@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190830033643.51019-6-gaoxiang25@huawei.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9364 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1908300125 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9364 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1908300125 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 30, 2019 at 11:36:42AM +0800, Gao Xiang wrote: > As Dan Carpenter suggested [1], I have to remove > all erofs likely/unlikely annotations. > > [1] https://lore.kernel.org/linux-fsdevel/20190829154346.GK23584@kadam/ > Reported-by: Dan Carpenter > Signed-off-by: Gao Xiang > --- Thanks! This is a nice readability improvement and I'm so sure it won't impact benchmarking at all. Acked-by: Dan Carpenter regards, dan carpenter