From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=FROM_EXCESS_BASE64, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67C1FC3A5A4 for ; Fri, 30 Aug 2019 09:34:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 37FAC2186A for ; Fri, 30 Aug 2019 09:34:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727896AbfH3Jel (ORCPT ); Fri, 30 Aug 2019 05:34:41 -0400 Received: from mx2.suse.de ([195.135.220.15]:46960 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725780AbfH3Jek (ORCPT ); Fri, 30 Aug 2019 05:34:40 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 87098AC37; Fri, 30 Aug 2019 09:34:39 +0000 (UTC) Date: Fri, 30 Aug 2019 11:34:37 +0200 From: Michal =?UTF-8?B?U3VjaMOhbmVr?= To: Marcel Holtmann Cc: Johan Hedberg , linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, oneukum@suse.com, acho@suse.com, tiwai@suse.com, jlee@suse.com Subject: Re: [PATCH] Revert "Bluetooth: btusb: driver to enable the usb-wakeup feature" Message-ID: <20190830113437.3508bce9@naga> In-Reply-To: References: <20190828121349.24966-1-msuchanek@suse.de> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 30 Aug 2019 09:49:35 +0200 Marcel Holtmann wrote: > Hi Michal, > > > This reverts commit a0085f2510e8976614ad8f766b209448b385492f. > > > > After this commit systems wake up at random, most commonly when > > > > - put to sleep while bluetooth audio stream is running > > - connected bluetooth audio device is powered off while system is > > asleep > > > > This is broken since the commit was merged up to 5.3-rc6. > > > > Signed-off-by: Michal Suchanek > > --- > > drivers/bluetooth/btusb.c | 5 ----- > > 1 file changed, 5 deletions(-) > > I think that Mario send in the same patch already. Yes, I found it after this copy was threaded with the previous one on lore.kernel.org. Anyway, there are multiple reasons why this is broken. AFAICT the wakeup feature is only workable with OSes that are able to wakeup into a small gadget that can check if the packet is interesting and put the system back to sleep if not without going through the whole online/offline everything sequence. Thanks Michal