From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10E4AC3A5A4 for ; Fri, 30 Aug 2019 12:17:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CDC1C21897 for ; Fri, 30 Aug 2019 12:17:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pnDI0maV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727883AbfH3MRH (ORCPT ); Fri, 30 Aug 2019 08:17:07 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:33914 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727326AbfH3MRH (ORCPT ); Fri, 30 Aug 2019 08:17:07 -0400 Received: by mail-pg1-f195.google.com with SMTP id n9so3492753pgc.1 for ; Fri, 30 Aug 2019 05:17:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=QBDazDOM2X7FA70xO+freU9rlh5XTVJr8JINQl4RCWU=; b=pnDI0maV5Rv5WyuaigzZDWVEE/YsPTOr9eMvQv6PwGZwmIjmVvxfGwPWbHoo4LFHva 7YtBD+fIbpmozffoEBVqOmjqJXt5IT28CIbqgxQD+D3gQisUzlViLcOOf3xBVec8rZwM 2rbQsHVBcDDYjlR0HBxNtvIMSs/0f1jEL6i1Ah5Be+AeR9QbYPXdU6ChynJY0OFhXfYA Fd4QqS2TakHZSqvV93f6J6SG2odRRThP8TKVEF05j+7ZcOgt3Fn/Po05MEjOEuAnsRWz EzH4f1XNKjy5hLf2CQgvNH1a5GJDPpdLT4SPtWPlq5BhlAOevbsK3Mqna0Yr2inVxtRH FarA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=QBDazDOM2X7FA70xO+freU9rlh5XTVJr8JINQl4RCWU=; b=oFrc8c/0/oHEM1CQBpihGE8juzLISog/Be2LgK5+FmI33kVIE1I0a5W8d+zAFriLsA bJbxUJ4UMU9WJw/rirkmw0wHIwVB7INwdRqWtYopEFpENjx+JO2tKQwywyP0Dr6SBxsk /nL4Z9UBSARHcoETVzxVLI6rLPEqJTk82tRUFwfl0yZbzAxJU81RJw7BJuwkOvnS4qvz KOQY3vMMieuBHKEVJXGKet7UqyvhFm/370Z8/6P6IPK4F9dMihOpbMN0WcgAeKQ7Hqs8 DWgKVRkIjvD1F/D0kYDV0HOjSXYMpKFQ6mRlKGnpWhj3vFQULg2RAsUe8E6ysAANpitB IMgw== X-Gm-Message-State: APjAAAX9+IKkzmNECrXF8W9PvV0dOekPEJ4yivIYGYfPe0mosgXdyNPD +BraqB7dMz8ZwABUxCxouTs= X-Google-Smtp-Source: APXvYqwChWOcfo60hRIMcjlLwn5Tgn1YVlHJTG1f190hzOo1p4I5EaJPzMWI+NmzZ+qKzQVb9ULp0Q== X-Received: by 2002:a63:394:: with SMTP id 142mr12773017pgd.43.1567167426427; Fri, 30 Aug 2019 05:17:06 -0700 (PDT) Received: from MeraComputer ([117.220.112.100]) by smtp.gmail.com with ESMTPSA id i137sm6827671pgc.4.2019.08.30.05.17.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Aug 2019 05:17:05 -0700 (PDT) Date: Fri, 30 Aug 2019 17:46:56 +0530 From: Prakhar Sinha To: gregkh@linuxfoundation.org, kim.jamie.bradley@gmail.com Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] staging: rts5208: Fixed checkpath warning. Message-ID: <20190830121656.GA2740@MeraComputer> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch solves the following checkpatch.pl's message in drivers/staging/rts5208/rtsx_transport.c:397. WARNING: line over 80 characters + option = RTSX_SG_VALID | RTSX_SG_END | RTSX_SG_TRANS_DATA; Signed-off-by: Prakhar Sinha --- Changes in v2: - Re-structured assignment to solve checkpath.pl's warning. drivers/staging/rts5208/rtsx_transport.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rts5208/rtsx_transport.c b/drivers/staging/rts5208/rtsx_transport.c index 8277d7895608..e61bc7c6ac33 100644 --- a/drivers/staging/rts5208/rtsx_transport.c +++ b/drivers/staging/rts5208/rtsx_transport.c @@ -393,10 +393,9 @@ static int rtsx_transfer_sglist_adma_partial(struct rtsx_chip *chip, u8 card, *offset = 0; *index = *index + 1; } - if ((i == (sg_cnt - 1)) || !resid) - option = RTSX_SG_VALID | RTSX_SG_END | RTSX_SG_TRANS_DATA; - else - option = RTSX_SG_VALID | RTSX_SG_TRANS_DATA; + option = RTSX_SG_VALID | RTSX_SG_TRANS_DATA; + if ((i == sg_cnt - 1) || !resid) + option |= RTSX_SG_END; rtsx_add_sg_tbl(chip, (u32)addr, (u32)len, option); -- 2.20.1