From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D127C3A5A4 for ; Fri, 30 Aug 2019 12:34:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3D72B21874 for ; Fri, 30 Aug 2019 12:34:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727923AbfH3Mew (ORCPT ); Fri, 30 Aug 2019 08:34:52 -0400 Received: from mga02.intel.com ([134.134.136.20]:54887 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727681AbfH3Mew (ORCPT ); Fri, 30 Aug 2019 08:34:52 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Aug 2019 05:34:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,447,1559545200"; d="scan'208";a="206076744" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga004.fm.intel.com with ESMTP; 30 Aug 2019 05:34:49 -0700 Received: from andy by smile with local (Exim 4.92.1) (envelope-from ) id 1i3g76-0007UY-G7; Fri, 30 Aug 2019 15:34:48 +0300 Date: Fri, 30 Aug 2019 15:34:48 +0300 From: Andy Shevchenko To: Sakari Ailus Cc: Petr Mladek , linux-kernel@vger.kernel.org, rafael@kernel.org, linux-acpi@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring Subject: Re: [PATCH v3 03/10] device property: Add functions for accessing node's parents Message-ID: <20190830123448.GB2680@smile.fi.intel.com> References: <20190829101043.24963-1-sakari.ailus@linux.intel.com> <20190829101043.24963-4-sakari.ailus@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190829101043.24963-4-sakari.ailus@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 29, 2019 at 01:10:36PM +0300, Sakari Ailus wrote: > Add two convenience functions for accessing node's parents: > > fwnode_count_parents() returns the number of parent nodes a given node > has. fwnode_get_nth_parent() returns node's parent at a given distance > from the node itself. > > Also reorder fwnode_get_parent() in property.c according to the same order > as in property.h. > +/** > + * fwnode_get_parent - Return parent firwmare node > + * @fwnode: Firmware whose parent is retrieved I guess you may leave this in the same location. The change will be more clear to review and smaller. -- With Best Regards, Andy Shevchenko