* [PATCH] unicode: Move static keyword to the front of declarations
@ 2019-08-30 13:13 Krzysztof Wilczynski
2019-09-03 19:52 ` Gabriel Krisman Bertazi
0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Wilczynski @ 2019-08-30 13:13 UTC (permalink / raw)
To: Gabriel Krisman Bertazi; +Cc: linux-fsdevel, linux-kernel
Move the static keyword to the front of declarations of nfdi_test_data
and nfdicf_test_data, and resolve the following compiler warnings that
can be seen when building with warnings enabled (W=1):
fs/unicode/utf8-selftest.c:38:1: warning:
‘static’ is not at beginning of declaration [-Wold-style-declaration]
fs/unicode/utf8-selftest.c:92:1: warning:
‘static’ is not at beginning of declaration [-Wold-style-declaration]
Signed-off-by: Krzysztof Wilczynski <kw@linux.com>
---
Related: https://lore.kernel.org/r/20190827233017.GK9987@google.com
fs/unicode/utf8-selftest.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/unicode/utf8-selftest.c b/fs/unicode/utf8-selftest.c
index 6c1a36bbf6ad..6fe8af7edccb 100644
--- a/fs/unicode/utf8-selftest.c
+++ b/fs/unicode/utf8-selftest.c
@@ -35,7 +35,7 @@ unsigned int total_tests;
#define test_f(cond, fmt, ...) _test(cond, __func__, __LINE__, fmt, ##__VA_ARGS__)
#define test(cond) _test(cond, __func__, __LINE__, "")
-const static struct {
+static const struct {
/* UTF-8 strings in this vector _must_ be NULL-terminated. */
unsigned char str[10];
unsigned char dec[10];
@@ -89,7 +89,7 @@ const static struct {
};
-const static struct {
+static const struct {
/* UTF-8 strings in this vector _must_ be NULL-terminated. */
unsigned char str[30];
unsigned char ncf[30];
--
2.22.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] unicode: Move static keyword to the front of declarations
2019-08-30 13:13 [PATCH] unicode: Move static keyword to the front of declarations Krzysztof Wilczynski
@ 2019-09-03 19:52 ` Gabriel Krisman Bertazi
0 siblings, 0 replies; 2+ messages in thread
From: Gabriel Krisman Bertazi @ 2019-09-03 19:52 UTC (permalink / raw)
To: Krzysztof Wilczynski; +Cc: linux-fsdevel, linux-kernel
Krzysztof Wilczynski <kw@linux.com> writes:
> Move the static keyword to the front of declarations of nfdi_test_data
> and nfdicf_test_data, and resolve the following compiler warnings that
> can be seen when building with warnings enabled (W=1):
>
> fs/unicode/utf8-selftest.c:38:1: warning:
> ‘static’ is not at beginning of declaration [-Wold-style-declaration]
>
> fs/unicode/utf8-selftest.c:92:1: warning:
> ‘static’ is not at beginning of declaration [-Wold-style-declaration]
>
Applied.
Thanks,
--
Gabriel Krisman Bertazi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-09-03 19:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-30 13:13 [PATCH] unicode: Move static keyword to the front of declarations Krzysztof Wilczynski
2019-09-03 19:52 ` Gabriel Krisman Bertazi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).