From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4AC1C3A5A7 for ; Fri, 30 Aug 2019 13:38:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A37F821670 for ; Fri, 30 Aug 2019 13:38:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727948AbfH3NiY (ORCPT ); Fri, 30 Aug 2019 09:38:24 -0400 Received: from smtp1.de.adit-jv.com ([93.241.18.167]:41455 "EHLO smtp1.de.adit-jv.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727780AbfH3NiY (ORCPT ); Fri, 30 Aug 2019 09:38:24 -0400 Received: from localhost (smtp1.de.adit-jv.com [127.0.0.1]) by smtp1.de.adit-jv.com (Postfix) with ESMTP id 42A593C0579; Fri, 30 Aug 2019 15:38:22 +0200 (CEST) Received: from smtp1.de.adit-jv.com ([127.0.0.1]) by localhost (smtp1.de.adit-jv.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xi7ekeR7DieB; Fri, 30 Aug 2019 15:38:16 +0200 (CEST) Received: from HI2EXCH01.adit-jv.com (hi2exch01.adit-jv.com [10.72.92.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by smtp1.de.adit-jv.com (Postfix) with ESMTPS id 89A243C04C0; Fri, 30 Aug 2019 15:38:16 +0200 (CEST) Received: from vmlxhi-102.adit-jv.com (10.72.93.184) by HI2EXCH01.adit-jv.com (10.72.92.24) with Microsoft SMTP Server (TLS) id 14.3.468.0; Fri, 30 Aug 2019 15:38:16 +0200 Date: Fri, 30 Aug 2019 15:38:13 +0200 From: Eugeniu Rosca To: "George G. Davis" CC: Shuah Khan , Jerry Hoemann , Colin Ian King , "open list:KERNEL SELFTEST FRAMEWORK" , open list , Eugeniu Rosca , Eugeniu Rosca Subject: Re: [PATCH v2] selftests: watchdog: Add optional file argument Message-ID: <20190830133813.GA23613@vmlxhi-102.adit-jv.com> References: <1567169597-10330-1-git-send-email-george_davis@mentor.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1567169597-10330-1-git-send-email-george_davis@mentor.com> User-Agent: Mutt/1.12.1+40 (7f8642d4ee82) (2019-06-28) X-Originating-IP: [10.72.93.184] Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi George, On Fri, Aug 30, 2019 at 08:53:16AM -0400, George G. Davis wrote: > Some systems have multiple watchdog devices where the first device > registered is assigned to the /dev/watchdog device file. In order > to test other watchdog devices, add an optional file argument for > selecting non-default watchdog devices for testing. > > Tested-by: Eugeniu Rosca > Signed-off-by: George G. Davis > --- > v1: > - https://lkml.org/lkml/2019/8/29/16 > v2: > - Update printf for ENOENT case based on report from Eugeniu Rosca Below interdiff [1] matches my expectations. Thanks! Reviewed-by: Eugeniu Rosca [1] interdiff <(git show patch_v1) <(git show patch_v2) diff -u b/tools/testing/selftests/watchdog/watchdog-test.c b/tools/testing/selftests/watchdog/watchdog-test.c --- b/tools/testing/selftests/watchdog/watchdog-test.c +++ b/tools/testing/selftests/watchdog/watchdog-test.c @@ -107,7 +107,7 @@ if (fd == -1) { if (errno == ENOENT) - printf("Watchdog device not enabled.\n"); + printf("Watchdog device (%s) not found.\n", file); else if (errno == EACCES) printf("Run watchdog as root.\n"); else -- Best Regards, Eugeniu.