From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: yu kuai <yukuai3@huawei.com>
Cc: linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org,
zhengbin13@huawei.com, yi.zhang@huawei.com
Subject: Re: [PATCH] xfs: add function name in xfs_trans_ail_delete function header comments
Date: Fri, 30 Aug 2019 08:15:36 -0700 [thread overview]
Message-ID: <20190830151536.GE5354@magnolia> (raw)
In-Reply-To: <1567162789-137056-1-git-send-email-yukuai3@huawei.com>
On Fri, Aug 30, 2019 at 06:59:49PM +0800, yu kuai wrote:
> Fix following warning:
> make W=1 fs/xfs/xfs_trans_ail.o
> fs/xfs/xfs_trans_ail.c:793: warning: Function parameter or member
> 'ailp' not described in 'xfs_trans_ail_delete'
> fs/xfs/xfs_trans_ail.c:793: warning: Function parameter or member
> 'lip' not described in 'xfs_trans_ail_delete'
> fs/xfs/xfs_trans_ail.c:793: warning: Function parameter or member
> 'shutdown_type' not described in 'xfs_trans_ail_delete'
>
> Since function parameters are described in the comments aready,
> there is no need to add parameter comments.
> Signed-off-by: yu kuai <yukuai3@huawei.com>
> ---
> fs/xfs/xfs_trans_ail.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/xfs/xfs_trans_ail.c b/fs/xfs/xfs_trans_ail.c
> index 6ccfd75..b69cf59 100644
> --- a/fs/xfs/xfs_trans_ail.c
> +++ b/fs/xfs/xfs_trans_ail.c
> @@ -764,8 +764,8 @@ xfs_ail_delete_one(
> return mlip == lip;
> }
>
> -/**
> - * Remove a log items from the AIL
> +/*
> + * xfs_trans_ail_delete - remove a log items from the AIL
> *
> * @xfs_trans_ail_delete_bulk takes an array of log items that all need to
xfs_trans_ail_delete_bulk no longer exists. xfs_trans_ail_delete does
not take an array of log items. The whole comment needs to be revised
since the bulk log itme delete code was pushed into _iflush_done:
See 27af1bbf52445996 ("xfs: remove xfs_trans_ail_delete_bulk")
Erp, my bad for letting that through. :(
--D
> * removed from the AIL. The caller is already holding the AIL lock, and done
> --
> 2.7.4
>
prev parent reply other threads:[~2019-08-30 15:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-30 10:59 [PATCH] xfs: add function name in xfs_trans_ail_delete function header comments yu kuai
2019-08-30 15:15 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190830151536.GE5354@magnolia \
--to=darrick.wong@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
--cc=zhengbin13@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).