From: "George G. Davis" <george_davis@mentor.com>
To: shuah <shuah@kernel.org>
Cc: Jerry Hoemann <jerry.hoemann@hpe.com>,
Colin Ian King <colin.king@canonical.com>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Eugeniu Rosca <erosca@de.adit-jv.com>
Subject: Re: [PATCH v2] selftests: watchdog: Add optional file argument
Date: Fri, 30 Aug 2019 15:36:49 -0400 [thread overview]
Message-ID: <20190830193648.GE23419@mam-gdavis-lt> (raw)
In-Reply-To: <ff4527a1-3b94-9b4a-b785-507eb861379c@kernel.org>
On Fri, Aug 30, 2019 at 10:20:23AM -0600, shuah wrote:
> On 8/30/19 10:13 AM, George G. Davis wrote:
> >On Fri, Aug 30, 2019 at 09:12:10AM -0600, shuah wrote:
> >>Can you split this line into two printf's. Checkpatch doesn't like
> >>it.
> >>
> >Sure, I'll add the following interdiff in v3:
>
> Thanks. This is what I am looking for. Please send v3 with thsi change.
Done.
> >>On a separate note, I wish this usage block uses \t instead of spacing
> >>things out.
> >
> >I noticed that most of those lines are hard spaced with only one using tabs.
> >To remain consistent with existing CodingStyle, I used hard spaces.
> >
>
> yes. My comment about using "\t" can be done later and if you would like
> to send for that patch, I will be happy to take it.
I'll send that along in a separate thread.
Thanks!
--
Regards,
George
prev parent reply other threads:[~2019-08-30 19:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-30 12:53 [PATCH v2] selftests: watchdog: Add optional file argument George G. Davis
2019-08-30 13:38 ` Eugeniu Rosca
2019-08-30 14:26 ` George G. Davis
2019-08-30 15:12 ` shuah
2019-08-30 16:13 ` George G. Davis
2019-08-30 16:20 ` shuah
2019-08-30 19:36 ` George G. Davis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190830193648.GE23419@mam-gdavis-lt \
--to=george_davis@mentor.com \
--cc=colin.king@canonical.com \
--cc=erosca@de.adit-jv.com \
--cc=jerry.hoemann@hpe.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).