From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>, Jiri Olsa <jolsa@redhat.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>
Subject: Re: [PATCH 4/4] perf intel-pt: Use shared x86 insn decoder
Date: Fri, 30 Aug 2019 17:06:20 -0300 [thread overview]
Message-ID: <20190830200620.GK28011@kernel.org> (raw)
In-Reply-To: <20190830195937.GJ28011@kernel.org>
Em Fri, Aug 30, 2019 at 04:59:37PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Thu, Aug 29, 2019 at 05:41:21PM -0500, Josh Poimboeuf escreveu:
> > +++ b/tools/perf/util/intel-pt-decoder/Build
> > @@ -1,7 +1,7 @@
> > perf-$(CONFIG_AUXTRACE) += intel-pt-pkt-decoder.o intel-pt-insn-decoder.o intel-pt-log.o intel-pt-decoder.o
> >
> > -inat_tables_script = util/intel-pt-decoder/gen-insn-attr-x86.awk
> > -inat_tables_maps = util/intel-pt-decoder/x86-opcode-map.txt
> > +inat_tables_script = ../../arch/x86/tools/gen-insn-attr-x86.awk
> > +inat_tables_maps = ../../arch/x86/lib/x86-opcode-map.txt
>
> I'm having trouble building it from:
>
> [acme@quaco perf]$ make help | grep perf
> perf-tar-src-pkg - Build perf-5.3.0-rc6.tar source tarball
> perf-targz-src-pkg - Build perf-5.3.0-rc6.tar.gz source tarball
> perf-tarbz2-src-pkg - Build perf-5.3.0-rc6.tar.bz2 source tarball
> perf-tarxz-src-pkg - Build perf-5.3.0-rc6.tar.xz source tarball
>
> I.e. detached tarballs, outside the kernel source tree, also using O=
>
> [acme@quaco perf]$ ls -la perf-5*
> ls: cannot access 'perf-5*': No such file or directory
> [acme@quaco perf]$ make perf-tarxz-src-pkg ; ls -la perf-5.*
> TAR
> PERF_VERSION = 5.3.rc6.gc55f04097932
> -rw-rw-r--. 1 acme acme 1670016 Aug 30 16:57 perf-5.3.0-rc6.tar.xz
> LD /tmp/build/perf/tests/perf-in.o
> CC /tmp/build/perf/util/auxtrace.o
> make[5]: *** No rule to make target '../../arch/x86/tools/gen-insn-attr-x86.awk', needed by '/tmp/build/perf/util/intel-pt-decoder/inat-tables.c'. Stop.
> make[5]: *** Waiting for unfinished jobs....
A fix, please lemme know if you're ok, so that I can fold both patches
so that we can keep it all bisect happy.
- Arnaldo
commit 423a2bf6e04aaecbeb5c2d5689cb3b832c240df0
Author: Arnaldo Carvalho de Melo <acme@redhat.com>
Date: Fri Aug 30 17:01:58 2019 -0300
srcdir awk
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
diff --git a/tools/perf/util/intel-pt-decoder/Build b/tools/perf/util/intel-pt-decoder/Build
index 1530f5cfd1b8..bc629359826f 100644
--- a/tools/perf/util/intel-pt-decoder/Build
+++ b/tools/perf/util/intel-pt-decoder/Build
@@ -1,7 +1,7 @@
perf-$(CONFIG_AUXTRACE) += intel-pt-pkt-decoder.o intel-pt-insn-decoder.o intel-pt-log.o intel-pt-decoder.o
-inat_tables_script = ../../arch/x86/tools/gen-insn-attr-x86.awk
-inat_tables_maps = ../../arch/x86/lib/x86-opcode-map.txt
+inat_tables_script = $(srctree)/tools/arch/x86/tools/gen-insn-attr-x86.awk
+inat_tables_maps = $(srctree)/tools/arch/x86/lib/x86-opcode-map.txt
$(OUTPUT)util/intel-pt-decoder/inat-tables.c: $(inat_tables_script) $(inat_tables_maps)
$(call rule_mkdir)
next prev parent reply other threads:[~2019-08-30 20:06 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-29 22:41 [PATCH 0/4] objtool,perf: Use shared x86 insn decoder Josh Poimboeuf
2019-08-29 22:41 ` [PATCH 1/4] objtool: Move x86 insn decoder to a common location Josh Poimboeuf
2019-09-02 8:16 ` [tip: perf/core] " tip-bot2 for Josh Poimboeuf
2019-08-29 22:41 ` [PATCH 2/4] perf: Update .gitignore file Josh Poimboeuf
2019-09-02 8:16 ` [tip: perf/core] " tip-bot2 for Josh Poimboeuf
2019-08-29 22:41 ` [PATCH 3/4] perf intel-pt: Remove inat.c from build dependency list Josh Poimboeuf
2019-09-02 8:16 ` [tip: perf/core] " tip-bot2 for Josh Poimboeuf
2019-08-29 22:41 ` [PATCH 4/4] perf intel-pt: Use shared x86 insn decoder Josh Poimboeuf
2019-08-30 19:59 ` Arnaldo Carvalho de Melo
2019-08-30 20:06 ` Arnaldo Carvalho de Melo [this message]
2019-08-30 20:10 ` Josh Poimboeuf
2019-09-02 8:16 ` [tip: perf/core] " tip-bot2 for Josh Poimboeuf
2019-08-30 7:19 ` [PATCH 0/4] objtool,perf: " Peter Zijlstra
2019-08-30 15:20 ` Masami Hiramatsu
2019-08-30 15:41 ` Arnaldo Carvalho de Melo
2019-08-30 18:40 ` Arnaldo Carvalho de Melo
2019-08-30 19:00 ` Arnaldo Carvalho de Melo
2019-08-30 19:31 ` Josh Poimboeuf
2019-08-30 19:48 ` Arnaldo Carvalho de Melo
2019-08-31 1:51 ` Masami Hiramatsu
2019-08-31 20:19 ` Arnaldo Carvalho de Melo
2019-09-01 2:36 ` Masami Hiramatsu
2019-09-02 8:16 ` [tip: perf/core] objtool: Update sync-check.sh from perf's check-headers.sh tip-bot2 for Arnaldo Carvalho de Melo
2019-09-02 8:16 ` [tip: perf/core] objtool: Ignore intentional differences for the x86 insn decoder tip-bot2 for Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190830200620.GK28011@kernel.org \
--to=arnaldo.melo@gmail.com \
--cc=adrian.hunter@intel.com \
--cc=jolsa@redhat.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).