From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C6D9C3A59B for ; Fri, 30 Aug 2019 23:18:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5D5CC23431 for ; Fri, 30 Aug 2019 23:18:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=joelfernandes.org header.i=@joelfernandes.org header.b="mJNxoFoP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728309AbfH3XSg (ORCPT ); Fri, 30 Aug 2019 19:18:36 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:38995 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728242AbfH3XSf (ORCPT ); Fri, 30 Aug 2019 19:18:35 -0400 Received: by mail-pg1-f194.google.com with SMTP id u17so4251822pgi.6 for ; Fri, 30 Aug 2019 16:18:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=PRkLiK2zQKW37sHjUWJi7ClUsfSJsVnDy5LzPyDzYvE=; b=mJNxoFoPw68Pczu3Q5Tl9Hubb1oPwPMN4HNOUR5BMqcq1lrDlYBVP6S84iC0HCLgRk bxc9EPapppZF4nytHiwbl/a1svpheNULWsFifiCEEtJxbx/2Nd5ec0nyECglpbsmGi7n tU+hvwsEYwTZP9DetuJiTg4UUwmi2g/IyPVjU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=PRkLiK2zQKW37sHjUWJi7ClUsfSJsVnDy5LzPyDzYvE=; b=W1mHCFvT6/ceN8g5V/E8xyBXxJqoPMIy5Iv2sv+0rRJ5MWYjrC/bxRwoYPe8ooXR1I 7Jd5/z6ltVlrJgyreNhwoHo+O8g+8ADKtTXwXU4iBMvc3TWZkySu0/SThSP+31ynN9BA nt0KVZCI2UnWC13yMm+W5APJ7hkFe396iaRT2JVJd/SOL1A9MD9OVT9hkELqbLdyVf27 nzTKPmu+RCQdhIXOcQIQMN82NcigXad/psWb/tspydENPoMkxp/WRhIZVHi7+bowXtBU ZEXxzVgFhhDPhPqQ/yrhyWh1+buTR6S36q/qhH6kApE5R35biwiw6Dk2VZjSqfxd/hcc VJhQ== X-Gm-Message-State: APjAAAXFhTnOKzphQsFJYRrWKw3cHIl2TLaSCNc4pBIyDdhgTy4JoPq5 mLzf3MCE3qWZ0cINZBSOlCwU37FTA2o= X-Google-Smtp-Source: APXvYqwWcIpjQmKfZ2KNw+QhAexpYhPxvb+SAlTByxWo8nuTzYepBvzn5LLXes3DPdl/v5VIIOmnfg== X-Received: by 2002:a17:90a:bc06:: with SMTP id w6mr1009296pjr.45.1567207114673; Fri, 30 Aug 2019 16:18:34 -0700 (PDT) Received: from joelaf.cam.corp.google.com ([2620:15c:6:12:9c46:e0da:efbf:69cc]) by smtp.gmail.com with ESMTPSA id t23sm8479395pfl.154.2019.08.30.16.18.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Aug 2019 16:18:33 -0700 (PDT) From: "Joel Fernandes (Google)" To: linux-kernel@vger.kernel.org Cc: "Joel Fernandes (Google)" , Andrew Morton , Arnd Bergmann , Bjorn Helgaas , Catalin Marinas , "Gustavo A. R. Silva" , Jonathan Derrick , Keith Busch , linux-pci@vger.kernel.org, Lorenzo Pieralisi Subject: [PATCH 1/2] pci: Convert to use built-in RCU list checking Date: Fri, 30 Aug 2019 19:18:16 -0400 Message-Id: <20190830231817.76862-1-joel@joelfernandes.org> X-Mailer: git-send-email 2.23.0.187.g17f5b7556c-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org CONFIG_PROVE_RCU_LIST requires list_for_each_entry_rcu() to pass a lockdep expression if using srcu or locking for protection. It can only check regular RCU protection, all other protection needs to be passed as lockdep expression. Signed-off-by: Joel Fernandes (Google) --- drivers/pci/controller/vmd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/pci/controller/vmd.c b/drivers/pci/controller/vmd.c index 4575e0c6dc4b..127631d0c6da 100644 --- a/drivers/pci/controller/vmd.c +++ b/drivers/pci/controller/vmd.c @@ -718,7 +718,8 @@ static irqreturn_t vmd_irq(int irq, void *data) int idx; idx = srcu_read_lock(&irqs->srcu); - list_for_each_entry_rcu(vmdirq, &irqs->irq_list, node) + list_for_each_entry_rcu(vmdirq, &irqs->irq_list, node, + srcu_read_lock_held(&irqs->srcu)) generic_handle_irq(vmdirq->virq); srcu_read_unlock(&irqs->srcu, idx); -- 2.23.0.187.g17f5b7556c-goog