From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2561FC3A5A6 for ; Sat, 31 Aug 2019 20:55:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EBF3222CE9 for ; Sat, 31 Aug 2019 20:55:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567284936; bh=P63HerPObzTc938dm+zm3rH2+JwBChOwkiyQow1XcKU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=kaesB/0InI7r27aNzdJTqId8eqWuFmlKN0VwoePrmMd1ydykHqKbTvEMjjVjVqbyB fnYzD+nIyLZluusFGk0GdaHFPrhJmAOfAQZhPrET/q8fsK7n46j4Xy8jIDeYPGgfRO 57W14+BGRuqfb+hG3wN4gsia8jZeR8OAUBW8HWyA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728621AbfHaUzd (ORCPT ); Sat, 31 Aug 2019 16:55:33 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:43163 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727538AbfHaUzd (ORCPT ); Sat, 31 Aug 2019 16:55:33 -0400 Received: by mail-pg1-f196.google.com with SMTP id u72so1082269pgb.10 for ; Sat, 31 Aug 2019 13:55:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=iTsu+i5V+uOh4NWIxid/z2sWPR9ERFgbEIMqA93uhyQ=; b=ZVf9AhTql7V2pCAEnGWITu2mOjRVxdCzHBR7IchamVIOG7NlDkNWuL9A4WB6UVhUnO qOIQwHzQx2tOyc5i9Berj6if4m0H5kjLofyR+CrrrpGuDldvhXqvBn79xy2Ebjl5pGat MlxRYfKmvEtfhZYkRfurhswBBaIyIkchVAxRdtVV4efg/aLmni9amCEIUuRnW8xcHT23 1sXYXggsF0uaF3Dgo3TIXOCO0sSJf6k8Ousge7GBVLed0UqKpCbsURyGalaZYiqQQR+I k4YLk2Uqe8U8RxKcI6tc554b92z/e2tID1sWmUehlwkcvZ9xCmmjDRlbU7g2DguCht7l oTsQ== X-Gm-Message-State: APjAAAWD50svlKXZfh/j21d/TAcjf6TYkA/3Ovr272hEucrVQLiiW/Yg 1m2dTy0jd0yCLuux2JBHbgRiZ9l+DUQ= X-Google-Smtp-Source: APXvYqygQvjD8Omqym2BxCXukxsDFhPW2JbUzw4XuQF5/NqX/nnnTIVk5zDdG1OX9uUE/0cVoSRW7g== X-Received: by 2002:a63:755e:: with SMTP id f30mr18700233pgn.246.1567284932358; Sat, 31 Aug 2019 13:55:32 -0700 (PDT) Received: from localhost ([2601:647:5b80:29f7:1bdd:d748:9a4e:8083]) by smtp.gmail.com with ESMTPSA id m9sm11120055pfh.84.2019.08.31.13.55.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 31 Aug 2019 13:55:31 -0700 (PDT) Date: Sat, 31 Aug 2019 13:55:30 -0700 From: Moritz Fischer To: Stephen Boyd Cc: linux-kernel@vger.kernel.org, Moritz Fischer , linux-fpga@vger.kernel.org, Greg Kroah-Hartman Subject: Re: [PATCH v6 14/57] fpga: Remove dev_err() usage after platform_get_irq() Message-ID: <20190831205530.GA24385@archbox> References: <20190730181557.90391-1-swboyd@chromium.org> <20190730181557.90391-15-swboyd@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190730181557.90391-15-swboyd@chromium.org> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 30, 2019 at 11:15:14AM -0700, Stephen Boyd wrote: > We don't need dev_err() messages when platform_get_irq() fails now that > platform_get_irq() prints an error message itself when something goes > wrong. Let's remove these prints with a simple semantic patch. > > // > @@ > expression ret; > struct platform_device *E; > @@ > > ret = > ( > platform_get_irq(E, ...) > | > platform_get_irq_byname(E, ...) > ); > > if ( \( ret < 0 \| ret <= 0 \) ) > { > ( > -if (ret != -EPROBE_DEFER) > -{ ... > -dev_err(...); > -... } > | > ... > -dev_err(...); > ) > ... > } > // > > While we're here, remove braces on if statements that only have one > statement (manually). > > Cc: Moritz Fischer > Cc: linux-fpga@vger.kernel.org > Cc: Greg Kroah-Hartman > Signed-off-by: Stephen Boyd > --- > > Please apply directly to subsystem trees > > drivers/fpga/zynq-fpga.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/fpga/zynq-fpga.c b/drivers/fpga/zynq-fpga.c > index 31ef38e38537..ee7765049607 100644 > --- a/drivers/fpga/zynq-fpga.c > +++ b/drivers/fpga/zynq-fpga.c > @@ -578,10 +578,8 @@ static int zynq_fpga_probe(struct platform_device *pdev) > init_completion(&priv->dma_done); > > priv->irq = platform_get_irq(pdev, 0); > - if (priv->irq < 0) { > - dev_err(dev, "No IRQ available\n"); > + if (priv->irq < 0) > return priv->irq; > - } > > priv->clk = devm_clk_get(dev, "ref_clk"); > if (IS_ERR(priv->clk)) { > -- > Sent by a computer through tubes > Applied to for-next. If all goes well I'll queue it for next PR.