From: Gao Xiang <hsiangkao@aol.com>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: "Dave Chinner" <david@fromorbit.com>,
"Valdis Klētnieks" <valdis.kletnieks@vt.edu>,
"Christoph Hellwig" <hch@infradead.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Sasha Levin" <alexander.levin@microsoft.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/staging/exfat - by default, prohibit mount of fat/vfat
Date: Sun, 1 Sep 2019 11:26:02 +0800 [thread overview]
Message-ID: <20190901032556.GA10186@hsiangkao-HP-ZHAN-66-Pro-G1> (raw)
In-Reply-To: <20190901030514.GC1131@ZenIV.linux.org.uk>
Hi Al,
On Sun, Sep 01, 2019 at 04:05:14AM +0100, Al Viro wrote:
> On Sun, Sep 01, 2019 at 09:37:19AM +0800, Gao Xiang wrote:
>
> > fs/orangefs/file.c
> > 19 static int flush_racache(struct inode *inode)
>
> Just why the hell would _that_ one be a problem? It's static in
> file; it can't pollute the namespace even if linked into the
> kernel.
>
> Folks, let's keep at least some degree of sanity - this is sinking
> to the level of certain killfile denizens...
Thanks for your kind reply. I think in the same way.
And Christoph did many great suggestions for erofs, thanks him
for erofs, and I'm already fixed most of them, and some
suggestions I have no idea to do....
1) add "erofs_" to all functions [1] [2];
2) avoid sb_bread and use read_mapping_page, actually
read_mapping_page will call block_read_full_page and
buffer_heads still there;
and I don't know what erofs "rapidly turning" means, all great
suggestions I can fix them all, I have no idea it's a bad thing.
[1] https://lore.kernel.org/linux-fsdevel/20190830163910.GB29603@infradead.org/
[2] https://lore.kernel.org/linux-fsdevel/20190831064853.GA162401@architecture4/
Thanks,
Gao Xiang
next prev parent reply other threads:[~2019-09-01 3:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-30 16:42 [PATCH] drivers/staging/exfat - by default, prohibit mount of fat/vfat Valdis Klētnieks
2019-08-30 16:45 ` Christoph Hellwig
2019-08-31 0:48 ` Valdis Klētnieks
2019-08-31 6:46 ` Christoph Hellwig
2019-08-31 10:25 ` Valdis Klētnieks
2019-08-31 14:24 ` Andy Shevchenko
2019-08-31 14:51 ` Valdis Klētnieks
2019-09-01 1:07 ` Dave Chinner
2019-09-01 1:37 ` Gao Xiang
2019-09-01 3:05 ` Al Viro
2019-09-01 3:26 ` Gao Xiang [this message]
2019-09-01 3:37 ` Valdis Klētnieks
2019-09-01 22:43 ` Dave Chinner
2019-09-01 23:13 ` Valdis Klētnieks
2019-09-02 7:38 ` Christoph Hellwig
2019-09-02 7:35 ` Christoph Hellwig
2019-09-02 15:25 ` Greg Kroah-Hartman
2019-09-02 19:00 ` Valdis Klētnieks
2019-09-02 19:06 ` Greg Kroah-Hartman
2019-09-08 10:50 ` OGAWA Hirofumi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190901032556.GA10186@hsiangkao-HP-ZHAN-66-Pro-G1 \
--to=hsiangkao@aol.com \
--cc=alexander.levin@microsoft.com \
--cc=david@fromorbit.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=valdis.kletnieks@vt.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).