From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH -next RESEND] tracing: fix iomap.h build warnings
Date: Sun, 1 Sep 2019 14:10:36 -0700 [thread overview]
Message-ID: <20190901211036.GC568270@magnolia> (raw)
In-Reply-To: <8a706c7b-5209-4bdd-e09f-5c2d619d75f5@infradead.org>
On Sat, Aug 31, 2019 at 01:25:37PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix 30 warnings for missing "struct inode" declaration (like these) by
> adding a forward reference for it.
> These warnings come from 'headers_check' (CONFIG_HEADERS_CHECK):
> CC include/trace/events/iomap.h.s
>
> ./../include/trace/events/iomap.h:49:18: warning: 'struct inode' declared inside parameter list will not be visible outside of this definition or declaration
> ./../include/trace/events/iomap.h:77:18: warning: 'struct inode' declared inside parameter list will not be visible outside of this definition or declaration
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Steven Rostedt <rostedt@goodmis.org>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> Resend to correct maintainer(s).
Looks ok, will add it to my tree. Thanks for the patch. :)
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
>
> include/trace/events/iomap.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> --- linux-next-20190829.orig/include/trace/events/iomap.h
> +++ linux-next-20190829/include/trace/events/iomap.h
> @@ -44,6 +44,8 @@ DECLARE_EVENT_CLASS(iomap_page_class,
> __entry->length)
> )
>
> +struct inode;
> +
> #define DEFINE_PAGE_EVENT(name) \
> DEFINE_EVENT(iomap_page_class, name, \
> TP_PROTO(struct inode *inode, struct page *page, unsigned long off, \
>
>
prev parent reply other threads:[~2019-09-01 21:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-31 20:25 [PATCH -next RESEND] tracing: fix iomap.h build warnings Randy Dunlap
2019-09-01 21:10 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190901211036.GC568270@magnolia \
--to=darrick.wong@oracle.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).