From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 783CCC3A59B for ; Mon, 2 Sep 2019 07:30:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5647023774 for ; Mon, 2 Sep 2019 07:30:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729791AbfIBHaX (ORCPT ); Mon, 2 Sep 2019 03:30:23 -0400 Received: from mga04.intel.com ([192.55.52.120]:9579 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729408AbfIBHaW (ORCPT ); Mon, 2 Sep 2019 03:30:22 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Sep 2019 00:30:22 -0700 X-IronPort-AV: E=Sophos;i="5.64,457,1559545200"; d="scan'208";a="357416837" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Sep 2019 00:30:19 -0700 Received: by paasikivi.fi.intel.com (Postfix, from userid 1000) id 3BA0C20B09; Mon, 2 Sep 2019 10:30:17 +0300 (EEST) Date: Mon, 2 Sep 2019 10:30:17 +0300 From: Sakari Ailus To: Andy Shevchenko Cc: Petr Mladek , linux-kernel@vger.kernel.org, rafael@kernel.org, linux-acpi@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring Subject: Re: [PATCH v3 03/10] device property: Add functions for accessing node's parents Message-ID: <20190902073017.GJ5475@paasikivi.fi.intel.com> References: <20190829101043.24963-1-sakari.ailus@linux.intel.com> <20190829101043.24963-4-sakari.ailus@linux.intel.com> <20190830123448.GB2680@smile.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190830123448.GB2680@smile.fi.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 30, 2019 at 03:34:48PM +0300, Andy Shevchenko wrote: > On Thu, Aug 29, 2019 at 01:10:36PM +0300, Sakari Ailus wrote: > > Add two convenience functions for accessing node's parents: > > > > fwnode_count_parents() returns the number of parent nodes a given node > > has. fwnode_get_nth_parent() returns node's parent at a given distance > > from the node itself. > > > > Also reorder fwnode_get_parent() in property.c according to the same order > > as in property.h. > > > +/** > > + * fwnode_get_parent - Return parent firwmare node > > + * @fwnode: Firmware whose parent is retrieved > > I guess you may leave this in the same location. The change will be more clear > to review and smaller. I added a separate patch that just moves it up. -- Sakari Ailus sakari.ailus@linux.intel.com