From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: Petr Mladek <pmladek@suse.com>,
linux-kernel@vger.kernel.org, rafael@kernel.org,
linux-acpi@vger.kernel.org, devicetree@vger.kernel.org,
Rob Herring <robh@kernel.org>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>
Subject: Re: [PATCH v4 03/11] device property: Move fwnode_get_parent() up
Date: Mon, 2 Sep 2019 13:11:53 +0300 [thread overview]
Message-ID: <20190902101153.GA2680@smile.fi.intel.com> (raw)
In-Reply-To: <20190902083240.20367-4-sakari.ailus@linux.intel.com>
On Mon, Sep 02, 2019 at 11:32:32AM +0300, Sakari Ailus wrote:
> Move fwnode_get_parent() above fwnode_get_next_parent(), making the order
> the same as in the header file.
>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
> drivers/base/property.c | 26 +++++++++++++-------------
> 1 file changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/base/property.c b/drivers/base/property.c
> index 81bd01ed40427..3d9dffbe96378 100644
> --- a/drivers/base/property.c
> +++ b/drivers/base/property.c
> @@ -556,6 +556,19 @@ int device_add_properties(struct device *dev,
> }
> EXPORT_SYMBOL_GPL(device_add_properties);
>
> +/**
> + * fwnode_get_parent - Return parent firwmare node
> + * @fwnode: Firmware whose parent is retrieved
> + *
> + * Return parent firmware node of the given node if possible or %NULL if no
> + * parent was available.
> + */
> +struct fwnode_handle *fwnode_get_parent(const struct fwnode_handle *fwnode)
> +{
> + return fwnode_call_ptr_op(fwnode, get_parent);
> +}
> +EXPORT_SYMBOL_GPL(fwnode_get_parent);
> +
> /**
> * fwnode_get_next_parent - Iterate to the node's parent
> * @fwnode: Firmware whose parent is retrieved
> @@ -577,19 +590,6 @@ struct fwnode_handle *fwnode_get_next_parent(struct fwnode_handle *fwnode)
> }
> EXPORT_SYMBOL_GPL(fwnode_get_next_parent);
>
> -/**
> - * fwnode_get_parent - Return parent firwmare node
> - * @fwnode: Firmware whose parent is retrieved
> - *
> - * Return parent firmware node of the given node if possible or %NULL if no
> - * parent was available.
> - */
> -struct fwnode_handle *fwnode_get_parent(const struct fwnode_handle *fwnode)
> -{
> - return fwnode_call_ptr_op(fwnode, get_parent);
> -}
> -EXPORT_SYMBOL_GPL(fwnode_get_parent);
> -
> /**
> * fwnode_get_next_child_node - Return the next child node handle for a node
> * @fwnode: Firmware node to find the next child node for.
> --
> 2.20.1
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-09-02 10:11 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-02 8:32 [PATCH v4 00/11] Device property improvements, add %pfw format specifier Sakari Ailus
2019-09-02 8:32 ` [PATCH v4 01/11] software node: Get reference to parent swnode in get_parent op Sakari Ailus
2019-09-02 10:10 ` Andy Shevchenko
2019-09-02 8:32 ` [PATCH v4 02/11] software node: Make argument to to_software_node const Sakari Ailus
2019-09-02 8:32 ` [PATCH v4 03/11] device property: Move fwnode_get_parent() up Sakari Ailus
2019-09-02 10:11 ` Andy Shevchenko [this message]
2019-09-02 8:32 ` [PATCH v4 04/11] device property: Add functions for accessing node's parents Sakari Ailus
2019-09-02 10:14 ` Andy Shevchenko
2019-09-02 12:34 ` Sakari Ailus
2019-09-02 12:46 ` Andy Shevchenko
2019-09-02 8:32 ` [PATCH v4 05/11] device property: Add fwnode_get_name for returning the name of a node Sakari Ailus
2019-09-02 8:32 ` [PATCH v4 06/11] device property: Add a function to obtain a node's prefix Sakari Ailus
2019-09-02 10:16 ` Andy Shevchenko
2019-09-02 8:32 ` [PATCH v4 07/11] lib/vsprintf: Remove support for %pF and %pf in favour of %pS and %ps Sakari Ailus
2019-09-02 14:39 ` Petr Mladek
2019-09-02 16:01 ` Andy Shevchenko
2019-09-03 14:04 ` Petr Mladek
2019-09-06 6:59 ` Sakari Ailus
2019-09-02 8:32 ` [PATCH v4 08/11] lib/vsprintf: Make use of fwnode API to obtain node names and separators Sakari Ailus
2019-09-02 15:18 ` Petr Mladek
2019-09-02 15:41 ` Sakari Ailus
2019-09-02 8:32 ` [PATCH v4 09/11] lib/vsprintf: OF nodes are first and foremost, struct device_nodes Sakari Ailus
2019-09-02 10:21 ` Andy Shevchenko
2019-09-02 8:32 ` [PATCH v4 10/11] lib/vsprintf: Add %pfw conversion specifier for printing fwnode names Sakari Ailus
2019-09-03 13:06 ` Petr Mladek
2019-09-04 15:04 ` Sakari Ailus
2019-09-04 15:17 ` Andy Shevchenko
2019-09-04 15:39 ` Joe Perches
2019-09-04 15:54 ` Andy Shevchenko
2019-09-04 15:37 ` Joe Perches
2019-09-04 16:09 ` Sakari Ailus
2019-09-02 8:32 ` [PATCH v4 11/11] lib/test_printf: Add tests for %pfw printk modifier Sakari Ailus
2019-09-02 12:26 ` Andy Shevchenko
2019-09-02 13:09 ` Sakari Ailus
2019-09-03 13:38 ` Petr Mladek
2019-09-04 14:03 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190902101153.GA2680@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).