Re: [PATCH v2 5/9] s390: numa: check the node id consistently for s390

From: kbuild test robot <lkp@intel.com>
To: Yunsheng Lin <linyunsheng@huawei.com>
Cc: kbuild-all@01.org, catalin.marinas@arm.com, will@kernel.org,
	mingo@redhat.com, bp@alien8.de, rth@twiddle.net,
	ink@jurassic.park.msu.ru, mattst88@gmail.com,
	benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au,
	heiko.carstens@de.ibm.com, gor@linux.ibm.com,
	borntraeger@de.ibm.com, ysato@users.sourceforge.jp,
	dalias@libc.org, davem@davemloft.net, ralf@linux-mips.org,
	paul.burton@mips.com, jhogan@kernel.org, jiaxun.yang@flygoat.com,
	chenhc@lemote.com, akpm@linux-foundation.org, rppt@linux.ibm.com,
	anshuman.khandual@arm.com, tglx@linutronix.de, cai@lca.pw,
	robin.murphy@arm.com, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, hpa@zytor.com, x86@kernel.org,
	dave.hansen@linux.intel.com, luto@kernel.org,
	peterz@infradead.org, len.brown@intel.com, axboe@kernel.dk,
	dledford@redhat.com, jeffrey.t.kirsher@intel.com,
	linux-alpha@vger.kernel.org, nfont@linux.vnet.ibm.com,
	naveen.n.rao@linux.vnet.ibm.com, mwb@linux.vnet.ibm.com,
	linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org,
	linux-sh@vger.kernel.org, sparclinux@vger.kernel.org,
	tbogendoerfer@suse.de, linux-mips@vger.kernel.org,
	linuxarm@huawei.com
Subject: Re: [PATCH v2 5/9] s390: numa: check the node id consistently for s390
Date: Mon, 2 Sep 2019 12:05:19 +0800	[thread overview]
Message-ID: <201909021108.PNpZuBV8%lkp@intel.com> (raw)
In-Reply-To: <1567231103-13237-6-git-send-email-linyunsheng@huawei.com>

[-- Attachment #1: Type: text/plain, Size: 2283 bytes --]

Hi Yunsheng,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[cannot apply to v5.3-rc6 next-20190830]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Yunsheng-Lin/check-the-node-id-consistently-across-different-arches/20190901-143722
config: s390-allmodconfig (attached as .config)
compiler: s390-linux-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=s390 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from include/linux/topology.h:35:0,
                    from include/linux/gfp.h:9,
                    from include/linux/mm.h:10,
                    from include/linux/kvm_host.h:14,
                    from arch/s390/kernel/asm-offsets.c:11:
   arch/s390/include/asm/topology.h: In function 'cpumask_of_node':
>> arch/s390/include/asm/topology.h:84:18: error: wrong type argument to unary exclamation mark
     if (node < 0 || !node_to_cpumask_map[node])
                     ^
   make[2]: *** [arch/s390/kernel/asm-offsets.s] Error 1
   make[2]: Target '__build' not remade because of errors.
   make[1]: *** [prepare0] Error 2
   make[1]: Target 'prepare' not remade because of errors.
   make: *** [sub-make] Error 2
   43 real  4 user  3 sys  16.91% cpu 	make prepare

vim +84 arch/s390/include/asm/topology.h

    76	
    77	/* Returns a pointer to the cpumask of CPUs on node 'node'. */
    78	#define cpumask_of_node cpumask_of_node
    79	static inline const struct cpumask *cpumask_of_node(int node)
    80	{
    81		if (node >= nr_node_ids)
    82			return cpu_none_mask;
    83	
  > 84		if (node < 0 || !node_to_cpumask_map[node])
    85			return cpu_online_mask;
    86	
    87		return &node_to_cpumask_map[node];
    88	}
    89	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 55830 bytes --]