From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5348FC3A59E for ; Mon, 2 Sep 2019 13:06:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 30D3E2168B for ; Mon, 2 Sep 2019 13:06:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730755AbfIBNG0 (ORCPT ); Mon, 2 Sep 2019 09:06:26 -0400 Received: from mx2.suse.de ([195.135.220.15]:42918 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729761AbfIBNG0 (ORCPT ); Mon, 2 Sep 2019 09:06:26 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 7B1EFAC9A; Mon, 2 Sep 2019 13:06:24 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id 8B96BDA796; Mon, 2 Sep 2019 15:06:44 +0200 (CEST) Date: Mon, 2 Sep 2019 15:06:44 +0200 From: David Sterba To: Christoph Hellwig Cc: Gao Xiang , linux-fsdevel@vger.kernel.org, devel@driverdev.osuosl.org, Alexander Viro , LKML , Greg Kroah-Hartman , Andrew Morton , Stephen Rothwell , Theodore Ts'o , Pavel Machek , Amir Goldstein , "Darrick J . Wong" , Dave Chinner , Jaegeuk Kim , Jan Kara , Richard Weinberger , Linus Torvalds , linux-erofs@lists.ozlabs.org, Chao Yu , Miao Xie , Li Guifu , Fang Wei Subject: Re: [PATCH v8 11/24] erofs: introduce xattr & posixacl support Message-ID: <20190902130644.GT2752@suse.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Christoph Hellwig , Gao Xiang , linux-fsdevel@vger.kernel.org, devel@driverdev.osuosl.org, Alexander Viro , LKML , Greg Kroah-Hartman , Andrew Morton , Stephen Rothwell , Theodore Ts'o , Pavel Machek , Amir Goldstein , "Darrick J . Wong" , Dave Chinner , Jaegeuk Kim , Jan Kara , Richard Weinberger , Linus Torvalds , linux-erofs@lists.ozlabs.org, Chao Yu , Miao Xie , Li Guifu , Fang Wei References: <20190815044155.88483-1-gaoxiang25@huawei.com> <20190815044155.88483-12-gaoxiang25@huawei.com> <20190902125711.GA23462@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190902125711.GA23462@infradead.org> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 02, 2019 at 05:57:11AM -0700, Christoph Hellwig wrote: > > +config EROFS_FS_XATTR > > + bool "EROFS extended attributes" > > + depends on EROFS_FS > > + default y > > + help > > + Extended attributes are name:value pairs associated with inodes by > > + the kernel or by users (see the attr(5) manual page, or visit > > + for details). > > + > > + If unsure, say N. > > + > > +config EROFS_FS_POSIX_ACL > > + bool "EROFS Access Control Lists" > > + depends on EROFS_FS_XATTR > > + select FS_POSIX_ACL > > + default y > > Is there any good reason to make these optional these days? I objected against adding so many config options, not to say for the standard features. The various cache strategies or other implementation details have been removed but I agree that making xattr/acl configurable is not necessary as well.