From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: linux-integrity@vger.kernel.org,
Alexey Klimov <aklimov@redhat.com>,
Peter Huewe <peterhuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tpm: Remove duplicate code from caps_show() in tpm-sysfs.c
Date: Mon, 2 Sep 2019 16:35:20 +0300 [thread overview]
Message-ID: <20190902133520.evot6o35vr3bz5vq@linux.intel.com> (raw)
In-Reply-To: <20190830160902.iip5jr4yiqcjpz45@cantor>
On Fri, Aug 30, 2019 at 09:09:02AM -0700, Jerry Snitselaar wrote:
> On Thu Aug 29 19, Jarkko Sakkinen wrote:
> + /* TPM 1.1 */
> > + if (tpm1_getcap(chip, TPM_CAP_VERSION_1_1, &cap,
> > + "attempting to determine the 1.1 version",
> > + sizeof(cap.version1))) {
> > + version = &cap.version1;
:>
> Actually looking at this again, this seems wrong. The version
> assignment here should be below this if, or in an else block, yes?
Absolutely is in a wrong place.
I sent an updated patch:
https://patchwork.kernel.org/patch/11126741/
/Jarkko
prev parent reply other threads:[~2019-09-02 13:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-29 14:38 [PATCH] tpm: Remove duplicate code from caps_show() in tpm-sysfs.c Jarkko Sakkinen
2019-08-29 20:27 ` Jerry Snitselaar
2019-08-30 16:09 ` Jerry Snitselaar
2019-09-02 13:35 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190902133520.evot6o35vr3bz5vq@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=aklimov@redhat.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).