From: Sebastian Reichel <sre@kernel.org>
To: YueHaibing <yuehaibing@huawei.com>
Cc: linus.walleij@linaro.org, lee.jones@linaro.org,
loic.pallardy@st.com, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: Re: [PATCH v2] power: supply: ab8500: remove set but not used variables 'vbup33_vrtcn' and 'bup_vch_range'
Date: Mon, 2 Sep 2019 21:05:36 +0200 [thread overview]
Message-ID: <20190902190536.irlrzzvjvduvl2qd@earth.universe> (raw)
In-Reply-To: <20190717141848.31116-1-yuehaibing@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 1908 bytes --]
Hi,
On Wed, Jul 17, 2019 at 10:18:48PM +0800, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warnings:
>
> drivers/power/supply/ab8500_charger.c:
> In function ab8500_charger_init_hw_registers:
> drivers/power/supply/ab8500_charger.c:3013:24: warning:
> variable vbup33_vrtcn set but not used [-Wunused-but-set-variable]
> drivers/power/supply/ab8500_charger.c:3013:5: warning:
> variable bup_vch_range set but not used [-Wunused-but-set-variable]
>
> They are not used since commit 4c4268dc97c4 ("power:
> supply: ab8500: Drop AB8540/9540 support")
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> v2: Fix patch title
> ---
Thanks, queued.
-- Sebastian
> drivers/power/supply/ab8500_charger.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/power/supply/ab8500_charger.c b/drivers/power/supply/ab8500_charger.c
> index 30de448..270a48a 100644
> --- a/drivers/power/supply/ab8500_charger.c
> +++ b/drivers/power/supply/ab8500_charger.c
> @@ -3010,7 +3010,6 @@ static int ab8500_charger_usb_get_property(struct power_supply *psy,
> static int ab8500_charger_init_hw_registers(struct ab8500_charger *di)
> {
> int ret = 0;
> - u8 bup_vch_range = 0, vbup33_vrtcn = 0;
>
> /* Setup maximum charger current and voltage for ABB cut2.0 */
> if (!is_ab8500_1p1_or_earlier(di->parent)) {
> @@ -3111,12 +3110,6 @@ static int ab8500_charger_init_hw_registers(struct ab8500_charger *di)
> goto out;
> }
>
> - /* Backup battery voltage and current */
> - if (di->bm->bkup_bat_v > BUP_VCH_SEL_3P1V)
> - bup_vch_range = BUP_VCH_RANGE;
> - if (di->bm->bkup_bat_v == BUP_VCH_SEL_3P3V)
> - vbup33_vrtcn = VBUP33_VRTCN;
> -
> ret = abx500_set_register_interruptible(di->dev,
> AB8500_RTC,
> AB8500_RTC_BACKUP_CHG_REG,
> --
> 2.7.4
>
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2019-09-02 19:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-17 14:18 [PATCH v2] power: supply: ab8500: remove set but not used variables 'vbup33_vrtcn' and 'bup_vch_range' YueHaibing
2019-08-02 21:50 ` Linus Walleij
2019-09-02 19:05 ` Sebastian Reichel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190902190536.irlrzzvjvduvl2qd@earth.universe \
--to=sre@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=loic.pallardy@st.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).