From: Gerd Hoffmann <kraxel@redhat.com>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: dri-devel@lists.freedesktop.org, Jonathan Corbet <corbet@lwn.net>,
David Airlie <airlied@linux.ie>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Maxime Ripard <maxime.ripard@bootlin.com>,
Sean Paul <sean@poorly.run>
Subject: Re: [PATCH 1/5] drm/ttm: add drm_gem_ttm_print_info()
Date: Tue, 3 Sep 2019 08:15:24 +0200 [thread overview]
Message-ID: <20190903061524.v75akt6rmx5vow2n@sirius.home.kraxel.org> (raw)
In-Reply-To: <199bbf8d-68bc-ea99-723e-3b88045970c4@suse.de>
Hi,
> > + [ TTM_PL_SYSTEM ] = "system",
> > + [ TTM_PL_TT ] = "tt",
> > + [ TTM_PL_VRAM ] = "vram",
> > + [ TTM_PL_PRIV ] = "priv",
> > +
>
> This 'gap' in the array seems to be a problem for drivers that use these
> bits. Could the print logic be moved into s separate function that also
> takes the array as an argument?
Are there any drivers which actually use these bits and which therefore
might want to use a different array?
Also note they should not cause any problems (other than not being
printed). There is an explicit check here ...
> > + if (!plname[i])
> > + continue;
.. to skip unknown bits.
cheers,
Gerd
next prev parent reply other threads:[~2019-09-03 6:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190902124126.7700-1-kraxel@redhat.com>
2019-09-02 12:41 ` [PATCH 1/5] drm/ttm: add drm_gem_ttm_print_info() Gerd Hoffmann
2019-09-02 14:19 ` Thomas Zimmermann
2019-09-03 6:15 ` Gerd Hoffmann [this message]
2019-09-02 12:41 ` [PATCH 2/5] drm/vram: use drm_gem_ttm_print_info Gerd Hoffmann
2019-09-02 14:24 ` Thomas Zimmermann
2019-09-03 6:17 ` Gerd Hoffmann
2019-09-02 12:41 ` [PATCH 3/5] drm/vram: add vram-mm debugfs file Gerd Hoffmann
2019-09-02 14:34 ` Thomas Zimmermann
2019-09-03 6:20 ` Gerd Hoffmann
2019-09-02 12:41 ` [PATCH 4/5] drm/qxl: use drm_gem_object_funcs callbacks Gerd Hoffmann
2019-09-02 14:34 ` Thomas Zimmermann
2019-09-03 6:24 ` Gerd Hoffmann
2019-09-03 6:52 ` Thomas Zimmermann
2019-09-02 12:41 ` [PATCH 5/5] drm/qxl: use drm_gem_ttm_print_info Gerd Hoffmann
2019-09-02 14:42 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190903061524.v75akt6rmx5vow2n@sirius.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=airlied@linux.ie \
--cc=corbet@lwn.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@bootlin.com \
--cc=sean@poorly.run \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).