From: Guenter Roeck <linux@roeck-us.net>
To: Christoph Hellwig <hch@lst.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Lee Jones <lee.jones@linaro.org>,
Alan Stern <stern@rowland.harvard.edu>,
linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/6] mfd: don't select DMA_DECLARE_COHERENT for the sm501 and tc6393xb drivers
Date: Tue, 3 Sep 2019 04:51:33 -0700 [thread overview]
Message-ID: <20190903115133.GA3543@roeck-us.net> (raw)
On Tue, Sep 03, 2019 at 10:46:15AM +0200, Christoph Hellwig wrote:
> Now that these drivers use the usb localmem pool there is no need to
> select DMA_DECLARE_COHERENT.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Tested-by: Guenter Roeck <linux@roeck-us.net>
for SM501.
> ---
> drivers/mfd/Kconfig | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index f129f9678940..c8cbde59bbf6 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -1105,7 +1105,6 @@ config MFD_SI476X_CORE
> config MFD_SM501
> tristate "Silicon Motion SM501"
> depends on HAS_DMA
> - select DMA_DECLARE_COHERENT
> ---help---
> This is the core driver for the Silicon Motion SM501 multimedia
> companion chip. This device is a multifunction device which may
> @@ -1714,7 +1713,6 @@ config MFD_TC6393XB
> select GPIOLIB
> select MFD_CORE
> select MFD_TMIO
> - select DMA_DECLARE_COHERENT
> help
> Support for Toshiba Mobile IO Controller TC6393XB
>
> --
> 2.20.1
>
next reply other threads:[~2019-09-03 11:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-03 11:51 Guenter Roeck [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-09-03 8:46 usb dma_mask fixups Christoph Hellwig
2019-09-03 8:46 ` [PATCH 6/6] mfd: don't select DMA_DECLARE_COHERENT for the sm501 and tc6393xb drivers Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190903115133.GA3543@roeck-us.net \
--to=linux@roeck-us.net \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=usb-storage@lists.one-eyed-alien.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).