linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Andrei Leonvikov <andreil499@gmail.com>
Cc: bhelgaas@google.com, linux-pci@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] Fix ARI enabling for a NVME devices
Date: Tue, 3 Sep 2019 06:14:16 -0700	[thread overview]
Message-ID: <20190903131416.GA26756@infradead.org> (raw)
In-Reply-To: <20190903125315.10349-1-andreil499@gmail.com>

On Tue, Sep 03, 2019 at 12:53:15PM +0000, Andrei Leonvikov wrote:
> +	if ((dev->driver != NULL) && (strncmp(dev->driver->name, "nvme", 4) == 0)) {
> +		// for NVME device this field always zero, but ARI can be enabled
> +		pcie_capability_read_dword(bridge, PCI_EXP_DEVCAP2, &cap);
> +		if (!(cap & PCI_EXP_DEVCAP2_ARI))
> +			return;
> +	}

Besides the missing patch description, all the obvious style issues, and
the fact that you can't just check a driver name a here:

There are plenty NVMe drives that support the ARI capability, and I
don't know of any standard saying nvme device should be treated special.

  reply	other threads:[~2019-09-03 13:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-03 12:53 [PATCH 1/1] Fix ARI enabling for a NVME devices Andrei Leonvikov
2019-09-03 13:14 ` Christoph Hellwig [this message]
     [not found]   ` <CA+kE0xQ+z4f8xQ=8oRVcTMC-VsU5dyqVUWxuDamTy59_HTYOeg@mail.gmail.com>
2019-09-03 16:33     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190903131416.GA26756@infradead.org \
    --to=hch@infradead.org \
    --cc=andreil499@gmail.com \
    --cc=bhelgaas@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).