From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F1FEC3A5A2 for ; Tue, 3 Sep 2019 20:19:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4C83822CF8 for ; Tue, 3 Sep 2019 20:19:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727002AbfICUTK (ORCPT ); Tue, 3 Sep 2019 16:19:10 -0400 Received: from correo.us.es ([193.147.175.20]:57988 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726887AbfICUTJ (ORCPT ); Tue, 3 Sep 2019 16:19:09 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id E0700B6C65 for ; Tue, 3 Sep 2019 22:19:05 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id D3086D2B1E for ; Tue, 3 Sep 2019 22:19:05 +0200 (CEST) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id C2E0DB7FF6; Tue, 3 Sep 2019 22:19:05 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id B8CACD2B1F; Tue, 3 Sep 2019 22:19:03 +0200 (CEST) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Tue, 03 Sep 2019 22:19:03 +0200 (CEST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (sys.soleta.eu [212.170.55.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id 8A1E14265A5A; Tue, 3 Sep 2019 22:19:03 +0200 (CEST) Date: Tue, 3 Sep 2019 22:19:04 +0200 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Florian Westphal Cc: Leonardo Bras , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, bridge@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jozsef Kadlecsik , Roopa Prabhu , Nikolay Aleksandrov , "David S. Miller" Subject: Re: [PATCH v4 1/2] netfilter: Terminate rule eval if protocol=IPv6 and ipv6 module is disabled Message-ID: <20190903201904.npna6dt25ug5gwvd@salvia> References: <20190830181354.26279-1-leonardo@linux.ibm.com> <20190830181354.26279-2-leonardo@linux.ibm.com> <20190830205802.GS20113@breakpoint.cc> <99e3ef9c5ead1c95df697d49ab9cc83a95b0ac7c.camel@linux.ibm.com> <20190903164948.kuvtpy7viqhcmp77@salvia> <20190903170550.GA13660@breakpoint.cc> <20190903193155.v74ws47zcn6zrwpr@salvia> <20190903194809.GD13660@breakpoint.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190903194809.GD13660@breakpoint.cc> User-Agent: NeoMutt/20170113 (1.7.2) X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 03, 2019 at 09:48:09PM +0200, Florian Westphal wrote: > Pablo Neira Ayuso wrote: > > > > I was expecting we could find a way to handle this from br_netfilter > > > > alone itself. > > > > > > We can't because we support ipv6 fib lookups from the netdev family > > > as well. > > > > > > Alternative is to auto-accept ipv6 packets from the nf_tables eval loop, > > > but I think its worse. > > > > Could we add a restriction for nf_tables + br_netfilter + !ipv6. I > > mean, if this is an IPv6 packet, nf_tables is on and IPv6 module if > > off, then drop this packet? > > We could do that from nft_do_chain_netdev(). Indeed, this is all about the netdev case. Probably add something similar to nf_ip6_route() to deal with ip6_route_lookup() case? This is the one trigering the problem, right? BTW, how does nft_fib_ipv6 module kicks in if ipv6 module is not loaded? The symbol dependency would pull in the IPv6 module anyway.