From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=AD_PREFS, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EC3AC3A59E for ; Wed, 4 Sep 2019 22:26:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3CD0B2168B for ; Wed, 4 Sep 2019 22:26:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730579AbfIDW0u (ORCPT ); Wed, 4 Sep 2019 18:26:50 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:38702 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725965AbfIDW0t (ORCPT ); Wed, 4 Sep 2019 18:26:49 -0400 Received: from localhost (unknown [62.21.130.100]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 8271615286006; Wed, 4 Sep 2019 15:26:48 -0700 (PDT) Date: Wed, 04 Sep 2019 15:26:46 -0700 (PDT) Message-Id: <20190904.152646.1973211125417119901.davem@davemloft.net> To: hayeswang@realtek.com Cc: netdev@vger.kernel.org, nic_swsd@realtek.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] r8152: modify rtl8152_set_speed function From: David Miller In-Reply-To: <1394712342-15778-326-Taiwan-albertk@realtek.com> References: <1394712342-15778-326-Taiwan-albertk@realtek.com> X-Mailer: Mew version 6.8 on Emacs 26.2 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 04 Sep 2019 15:26:49 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hayes Wang Date: Mon, 2 Sep 2019 19:52:28 +0800 > First, for AUTONEG_DISABLE, we only need to modify MII_BMCR. > > Second, add advertising parameter for rtl8152_set_speed(). Add > RTL_ADVERTISED_xxx for advertising parameter of rtl8152_set_speed(). > Then, the advertising settings from ethtool could be saved. > > Signed-off-by: Hayes Wang Applied.