From: Vinod Koul <vkoul@kernel.org>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
dmaengine@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH] dmaengine: stm32-dma: Use struct_size() helper
Date: Wed, 4 Sep 2019 10:25:19 +0530 [thread overview]
Message-ID: <20190904045519.GZ2672@vkoul-mobl> (raw)
In-Reply-To: <20190830161423.GA3483@embeddedor>
On 30-08-19, 11:14, Gustavo A. R. Silva wrote:
> One of the more common cases of allocation size calculations is finding
> the size of a structure that has a zero-sized array at the end, along
> with memory for some number of elements for that array. For example:
>
> struct stm32_dma_desc {
> ...
> struct stm32_dma_sg_req sg_req[];
> };
>
>
> Make use of the struct_size() helper instead of an open-coded version
> in order to avoid any potential type mistakes.
>
> So, replace the following function:
>
> static struct stm32_dma_desc *stm32_dma_alloc_desc(u32 num_sgs)
> {
> return kzalloc(sizeof(struct stm32_dma_desc) +
> sizeof(struct stm32_dma_sg_req) * num_sgs, GFP_NOWAIT);
> }
>
> with:
>
> kzalloc(struct_size(desc, sg_req, num_sgs), GFP_NOWAIT)
>
> This code was detected with the help of Coccinelle.
Applied, thanks
--
~Vinod
prev parent reply other threads:[~2019-09-04 4:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-30 16:14 [PATCH] dmaengine: stm32-dma: Use struct_size() helper Gustavo A. R. Silva
2019-09-04 4:55 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190904045519.GZ2672@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=alexandre.torgue@st.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=gustavo@embeddedor.com \
--cc=keescook@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).