* [PATCH] dma: iop-adma.c: fix printk format warning
@ 2019-09-04 5:06 Randy Dunlap
2019-09-04 5:44 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2019-09-04 5:06 UTC (permalink / raw)
To: Vinod Koul, LKML; +Cc: Dan Williams
From: Randy Dunlap <rdunlap@infradead.org>
Fix printk format warning in iop-adma.c (seen on x86_64) by using
%pad:
../drivers/dma/iop-adma.c:118:12: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 6 has type ‘dma_addr_t {aka long long unsigned int}’ [-Wformat=]
Fixes: c211092313b9 ("dmaengine: driver for the iop32x, iop33x, and iop13xx raid engines")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Dan Williams <dan.j.williams@intel.com>
Acked-by: Dan Williams <dan.j.williams@intel.com>
---
v2: add Ack from Dan and update to current linux-next;
drivers/dma/iop-adma.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- linux-next-20190903.orig/drivers/dma/iop-adma.c
+++ linux-next-20190903/drivers/dma/iop-adma.c
@@ -116,9 +116,9 @@ static void __iop_adma_slot_cleanup(stru
list_for_each_entry_safe(iter, _iter, &iop_chan->chain,
chain_node) {
pr_debug("\tcookie: %d slot: %d busy: %d "
- "this_desc: %#x next_desc: %#llx ack: %d\n",
+ "this_desc: %pad next_desc: %#llx ack: %d\n",
iter->async_tx.cookie, iter->idx, busy,
- iter->async_tx.phys, (u64)iop_desc_get_next_desc(iter),
+ &iter->async_tx.phys, (u64)iop_desc_get_next_desc(iter),
async_tx_test_ack(&iter->async_tx));
prefetch(_iter);
prefetch(&_iter->async_tx);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] dma: iop-adma.c: fix printk format warning
2019-09-04 5:06 [PATCH] dma: iop-adma.c: fix printk format warning Randy Dunlap
@ 2019-09-04 5:44 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2019-09-04 5:44 UTC (permalink / raw)
To: Randy Dunlap; +Cc: LKML, Dan Williams
On 03-09-19, 22:06, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix printk format warning in iop-adma.c (seen on x86_64) by using
> %pad:
>
> ../drivers/dma/iop-adma.c:118:12: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 6 has type ‘dma_addr_t {aka long long unsigned int}’ [-Wformat=]
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-09-04 5:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-04 5:06 [PATCH] dma: iop-adma.c: fix printk format warning Randy Dunlap
2019-09-04 5:44 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).