From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Christoph Vogtländer" <Christoph.Vogtlaender@sigma-surface-science.com>
Cc: Jiri Slaby <jslaby@suse.com>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] serial: max310x: turn off transmitter before activating AutoCTS or auto transmitter flow control
Date: Wed, 4 Sep 2019 09:30:22 +0200 [thread overview]
Message-ID: <20190904073022.GB9729@kroah.com> (raw)
In-Reply-To: <bd9fb8e75d0e45218eb110c25bb539ef@SSSDEEX.i.sigma-surface-science.com>
On Fri, Aug 30, 2019 at 09:58:41AM +0000, Christoph Vogtländer wrote:
> As documented in the data-sheet, the transmitter must be disabled before
> activating AutoCTS or auto transmitter flow control. Accordingly, the
> transmitter must be enabled after AutoCTS or auto transmitter flow
> control gets deactivated.
>
> Signed-off-by: Christoph Vogtländer <c.vogtlaender@sigma-surface-science.com>
> ---
> drivers/tty/serial/max310x.c | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/drivers/tty/serial/max310x.c b/drivers/tty/serial/max310x.c
> index fb5a7e0e58e9..adfef6dae4a7 100644
> --- a/drivers/tty/serial/max310x.c
> +++ b/drivers/tty/serial/max310x.c
> @@ -860,6 +860,15 @@ static void max310x_set_termios(struct uart_port *port,
> max310x_port_write(port, MAX310X_XON1_REG, termios->c_cc[VSTART]);
> max310x_port_write(port, MAX310X_XOFF1_REG, termios->c_cc[VSTOP]);
>
> +/* Disable transmitter before enabling AutoCTS or auto transmitter
> + * flow control
> + */
> +if (termios->c_cflag & CRTSCTS || termios->c_iflag & IXOFF) {
> +max310x_port_update(port, MAX310X_MODE1_REG,
> + MAX310X_MODE1_TXDIS_BIT,
> + MAX310X_MODE1_TXDIS_BIT);
> +}
> +
> port->status &= ~(UPSTAT_AUTOCTS | UPSTAT_AUTORTS | UPSTAT_AUTOXOFF);
>
> if (termios->c_cflag & CRTSCTS) {
> @@ -878,6 +887,15 @@ static void max310x_set_termios(struct uart_port *port,
> }
> max310x_port_write(port, MAX310X_FLOWCTRL_REG, flow);
>
> +/* Enable transmitter after disabling AutoCTS and auto transmitter
> + * flow control
> + */
> +if (!(termios->c_cflag & CRTSCTS) && !(termios->c_iflag & IXOFF)) {
> +max310x_port_update(port, MAX310X_MODE1_REG,
> + MAX310X_MODE1_TXDIS_BIT,
> + 0);
> +}
> +
> /* Get baud rate generator configuration */
> baud = uart_get_baud_rate(port, termios, old,
> port->uartclk / 16 / 0xffff,
> --
> 2.22.1
>
Same problem here, this is impossible to apply.
greg k-h
next prev parent reply other threads:[~2019-09-04 7:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-30 9:58 [PATCH] serial: max310x: turn off transmitter before activating AutoCTS or auto transmitter flow control Christoph Vogtländer
2019-09-04 7:30 ` Greg Kroah-Hartman [this message]
2019-09-04 12:17 ` Christoph Vogtländer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190904073022.GB9729@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Christoph.Vogtlaender@sigma-surface-science.com \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).