* [PATCH] USB: dummy-hcd: fix power budget for SuperSpeed mode
@ 2019-09-04 7:52 Jacky.Cao
2019-09-04 7:54 ` Felipe Balbi
0 siblings, 1 reply; 12+ messages in thread
From: Jacky.Cao @ 2019-09-04 7:52 UTC (permalink / raw)
To: balbi, gregkh, linux-usb, linux-kernel; +Cc: Kento.A.Kobayashi, Jacky.Cao
The power budget for SuperSpeed mode should be 900 mA
according to USB3.0 specification, so set the power
budget to 900 mA for dummy_start_ss which is only used
for SuperSpeed mode.
If the max power consumption of SuperSpeed device is
larger than 500 mA, insufficient available bus power
error happens in usb_choose_configuration function
when the device connects to dummy hcd.
Signed-off-by: Jacky Cao <Jacky.Cao@sony.com>
---
drivers/usb/gadget/udc/dummy_hcd.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/udc/dummy_hcd.c b/drivers/usb/gadget/udc/dummy_hcd.c
index 8414fac..52f2cf5 100644
--- a/drivers/usb/gadget/udc/dummy_hcd.c
+++ b/drivers/usb/gadget/udc/dummy_hcd.c
@@ -48,6 +48,7 @@
#define DRIVER_VERSION "02 May 2005"
#define POWER_BUDGET 500 /* in mA; use 8 for low-power port testing */
+#define POWER_BUDGET_3_0 900 /* in mA */
static const char driver_name[] = "dummy_hcd";
static const char driver_desc[] = "USB Host+Gadget Emulator";
@@ -2432,7 +2433,7 @@ static int dummy_start_ss(struct dummy_hcd *dum_hcd)
dum_hcd->rh_state = DUMMY_RH_RUNNING;
dum_hcd->stream_en_ep = 0;
INIT_LIST_HEAD(&dum_hcd->urbp_list);
- dummy_hcd_to_hcd(dum_hcd)->power_budget = POWER_BUDGET;
+ dummy_hcd_to_hcd(dum_hcd)->power_budget = POWER_BUDGET_3_0;
dummy_hcd_to_hcd(dum_hcd)->state = HC_STATE_RUNNING;
dummy_hcd_to_hcd(dum_hcd)->uses_new_polling = 1;
#ifdef CONFIG_USB_OTG
--
2.7.4
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH] USB: dummy-hcd: fix power budget for SuperSpeed mode
2019-09-04 7:52 [PATCH] USB: dummy-hcd: fix power budget for SuperSpeed mode Jacky.Cao
@ 2019-09-04 7:54 ` Felipe Balbi
2019-09-04 7:58 ` Greg KH
2019-09-04 14:21 ` Alan Stern
0 siblings, 2 replies; 12+ messages in thread
From: Felipe Balbi @ 2019-09-04 7:54 UTC (permalink / raw)
To: Jacky.Cao, gregkh, linux-usb, linux-kernel, Alan Stern
Cc: Kento.A.Kobayashi, Jacky.Cao
[-- Attachment #1: Type: text/plain, Size: 1666 bytes --]
Hi,
<Jacky.Cao@sony.com> writes:
> The power budget for SuperSpeed mode should be 900 mA
> according to USB3.0 specification, so set the power
> budget to 900 mA for dummy_start_ss which is only used
> for SuperSpeed mode.
>
> If the max power consumption of SuperSpeed device is
> larger than 500 mA, insufficient available bus power
> error happens in usb_choose_configuration function
> when the device connects to dummy hcd.
>
> Signed-off-by: Jacky Cao <Jacky.Cao@sony.com>
> ---
> drivers/usb/gadget/udc/dummy_hcd.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/udc/dummy_hcd.c b/drivers/usb/gadget/udc/dummy_hcd.c
> index 8414fac..52f2cf5 100644
> --- a/drivers/usb/gadget/udc/dummy_hcd.c
> +++ b/drivers/usb/gadget/udc/dummy_hcd.c
> @@ -48,6 +48,7 @@
> #define DRIVER_VERSION "02 May 2005"
>
> #define POWER_BUDGET 500 /* in mA; use 8 for low-power port testing */
> +#define POWER_BUDGET_3_0 900 /* in mA */
>
> static const char driver_name[] = "dummy_hcd";
> static const char driver_desc[] = "USB Host+Gadget Emulator";
> @@ -2432,7 +2433,7 @@ static int dummy_start_ss(struct dummy_hcd *dum_hcd)
> dum_hcd->rh_state = DUMMY_RH_RUNNING;
> dum_hcd->stream_en_ep = 0;
> INIT_LIST_HEAD(&dum_hcd->urbp_list);
> - dummy_hcd_to_hcd(dum_hcd)->power_budget = POWER_BUDGET;
> + dummy_hcd_to_hcd(dum_hcd)->power_budget = POWER_BUDGET_3_0;
> dummy_hcd_to_hcd(dum_hcd)->state = HC_STATE_RUNNING;
> dummy_hcd_to_hcd(dum_hcd)->uses_new_polling = 1;
> #ifdef CONFIG_USB_OTG
Alan, I suppose you're okay with this change?
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] USB: dummy-hcd: fix power budget for SuperSpeed mode
2019-09-04 7:54 ` Felipe Balbi
@ 2019-09-04 7:58 ` Greg KH
2019-09-04 8:52 ` Jacky.Cao
2019-09-04 14:21 ` Alan Stern
1 sibling, 1 reply; 12+ messages in thread
From: Greg KH @ 2019-09-04 7:58 UTC (permalink / raw)
To: Felipe Balbi
Cc: Jacky.Cao, linux-usb, linux-kernel, Alan Stern, Kento.A.Kobayashi
On Wed, Sep 04, 2019 at 10:54:28AM +0300, Felipe Balbi wrote:
>
> Hi,
>
> <Jacky.Cao@sony.com> writes:
>
> > The power budget for SuperSpeed mode should be 900 mA
> > according to USB3.0 specification, so set the power
> > budget to 900 mA for dummy_start_ss which is only used
> > for SuperSpeed mode.
> >
> > If the max power consumption of SuperSpeed device is
> > larger than 500 mA, insufficient available bus power
> > error happens in usb_choose_configuration function
> > when the device connects to dummy hcd.
> >
> > Signed-off-by: Jacky Cao <Jacky.Cao@sony.com>
> > ---
> > drivers/usb/gadget/udc/dummy_hcd.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/usb/gadget/udc/dummy_hcd.c b/drivers/usb/gadget/udc/dummy_hcd.c
> > index 8414fac..52f2cf5 100644
> > --- a/drivers/usb/gadget/udc/dummy_hcd.c
> > +++ b/drivers/usb/gadget/udc/dummy_hcd.c
> > @@ -48,6 +48,7 @@
> > #define DRIVER_VERSION "02 May 2005"
> >
> > #define POWER_BUDGET 500 /* in mA; use 8 for low-power port testing */
> > +#define POWER_BUDGET_3_0 900 /* in mA */
> >
> > static const char driver_name[] = "dummy_hcd";
> > static const char driver_desc[] = "USB Host+Gadget Emulator";
> > @@ -2432,7 +2433,7 @@ static int dummy_start_ss(struct dummy_hcd *dum_hcd)
> > dum_hcd->rh_state = DUMMY_RH_RUNNING;
> > dum_hcd->stream_en_ep = 0;
> > INIT_LIST_HEAD(&dum_hcd->urbp_list);
> > - dummy_hcd_to_hcd(dum_hcd)->power_budget = POWER_BUDGET;
> > + dummy_hcd_to_hcd(dum_hcd)->power_budget = POWER_BUDGET_3_0;
> > dummy_hcd_to_hcd(dum_hcd)->state = HC_STATE_RUNNING;
> > dummy_hcd_to_hcd(dum_hcd)->uses_new_polling = 1;
> > #ifdef CONFIG_USB_OTG
>
> Alan, I suppose you're okay with this change?
I'm not ok with the whitespace damage making this patch impossible to
apply :)
^ permalink raw reply [flat|nested] 12+ messages in thread
* RE: [PATCH] USB: dummy-hcd: fix power budget for SuperSpeed mode
2019-09-04 7:58 ` Greg KH
@ 2019-09-04 8:52 ` Jacky.Cao
2019-09-04 10:01 ` Greg KH
0 siblings, 1 reply; 12+ messages in thread
From: Jacky.Cao @ 2019-09-04 8:52 UTC (permalink / raw)
To: gregkh, balbi
Cc: linux-usb, linux-kernel, stern, Kento.A.Kobayashi, Jacky.Cao
Hi,
> I'm not ok with the whitespace damage making this patch impossible to apply :)
Sorry for the whitespace damage issue I didn't notice when I copied the content.
Just now I submitted v2 for this patch with whitespace damage issue fix.
Please help to confirm, thank you.
Regards
Jacky
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] USB: dummy-hcd: fix power budget for SuperSpeed mode
2019-09-04 8:52 ` Jacky.Cao
@ 2019-09-04 10:01 ` Greg KH
0 siblings, 0 replies; 12+ messages in thread
From: Greg KH @ 2019-09-04 10:01 UTC (permalink / raw)
To: Jacky.Cao; +Cc: balbi, linux-usb, linux-kernel, stern, Kento.A.Kobayashi
On Wed, Sep 04, 2019 at 08:52:12AM +0000, Jacky.Cao@sony.com wrote:
> Hi,
>
> > I'm not ok with the whitespace damage making this patch impossible to apply :)
>
> Sorry for the whitespace damage issue I didn't notice when I copied the content.
> Just now I submitted v2 for this patch with whitespace damage issue fix.
> Please help to confirm, thank you.
You can always confirm your own submissions by looking on the mailing
list itself, no need to ask anyone else to do that :)
greg k-h
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] USB: dummy-hcd: fix power budget for SuperSpeed mode
2019-09-04 7:54 ` Felipe Balbi
2019-09-04 7:58 ` Greg KH
@ 2019-09-04 14:21 ` Alan Stern
2019-09-05 4:18 ` Jacky.Cao
1 sibling, 1 reply; 12+ messages in thread
From: Alan Stern @ 2019-09-04 14:21 UTC (permalink / raw)
To: Felipe Balbi
Cc: Jacky.Cao, gregkh, linux-usb, linux-kernel, Kento.A.Kobayashi
On Wed, 4 Sep 2019, Felipe Balbi wrote:
>
> Hi,
>
> <Jacky.Cao@sony.com> writes:
>
> > The power budget for SuperSpeed mode should be 900 mA
> > according to USB3.0 specification, so set the power
> > budget to 900 mA for dummy_start_ss which is only used
> > for SuperSpeed mode.
> >
> > If the max power consumption of SuperSpeed device is
> > larger than 500 mA, insufficient available bus power
> > error happens in usb_choose_configuration function
> > when the device connects to dummy hcd.
> >
> > Signed-off-by: Jacky Cao <Jacky.Cao@sony.com>
> > ---
> > drivers/usb/gadget/udc/dummy_hcd.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/usb/gadget/udc/dummy_hcd.c b/drivers/usb/gadget/udc/dummy_hcd.c
> > index 8414fac..52f2cf5 100644
> > --- a/drivers/usb/gadget/udc/dummy_hcd.c
> > +++ b/drivers/usb/gadget/udc/dummy_hcd.c
> > @@ -48,6 +48,7 @@
> > #define DRIVER_VERSION "02 May 2005"
> >
> > #define POWER_BUDGET 500 /* in mA; use 8 for low-power port testing */
> > +#define POWER_BUDGET_3_0 900 /* in mA */
> >
> > static const char driver_name[] = "dummy_hcd";
> > static const char driver_desc[] = "USB Host+Gadget Emulator";
> > @@ -2432,7 +2433,7 @@ static int dummy_start_ss(struct dummy_hcd *dum_hcd)
> > dum_hcd->rh_state = DUMMY_RH_RUNNING;
> > dum_hcd->stream_en_ep = 0;
> > INIT_LIST_HEAD(&dum_hcd->urbp_list);
> > - dummy_hcd_to_hcd(dum_hcd)->power_budget = POWER_BUDGET;
> > + dummy_hcd_to_hcd(dum_hcd)->power_budget = POWER_BUDGET_3_0;
> > dummy_hcd_to_hcd(dum_hcd)->state = HC_STATE_RUNNING;
> > dummy_hcd_to_hcd(dum_hcd)->uses_new_polling = 1;
> > #ifdef CONFIG_USB_OTG
>
> Alan, I suppose you're okay with this change?
Yes. Except that I think the name POWER_BUDGET_3_0 is a little odd.
It implies that this change is specific to USB 3.0 -- but it isn't.
USB 3.1 and 3.2 also have a 900 mA limit, right?
So please consider changing the name to POWER_BUDGET_3.
Alan Stern
^ permalink raw reply [flat|nested] 12+ messages in thread
* RE: [PATCH] USB: dummy-hcd: fix power budget for SuperSpeed mode
2019-09-04 14:21 ` Alan Stern
@ 2019-09-05 4:18 ` Jacky.Cao
0 siblings, 0 replies; 12+ messages in thread
From: Jacky.Cao @ 2019-09-05 4:18 UTC (permalink / raw)
To: stern, balbi
Cc: gregkh, linux-usb, linux-kernel, Kento.A.Kobayashi, Jacky.Cao
Hi
> Yes. Except that I think the name POWER_BUDGET_3_0 is a little odd.
> It implies that this change is specific to USB 3.0 -- but it isn't.
> USB 3.1 and 3.2 also have a 900 mA limit, right?
>
> So please consider changing the name to POWER_BUDGET_3.
>
> Alan Stern
Thank you for your comment.
I updated the name from POWER_BUDGET_3_0 to POWER_BUDGET_3 in PATCH v3
and submitted it just now.
Regards
Jacky
^ permalink raw reply [flat|nested] 12+ messages in thread
[parent not found: <16EA1F625E922C43B00B9D82250220500871C7D7@APYOKXMS108.ap.sony.com>]
* Re: [PATCH] USB: dummy-hcd: fix power budget for SuperSpeed mode
[not found] <16EA1F625E922C43B00B9D82250220500871C7D7@APYOKXMS108.ap.sony.com>
@ 2019-09-04 7:46 ` Felipe Balbi
2019-09-04 7:54 ` Jacky.Cao
0 siblings, 1 reply; 12+ messages in thread
From: Felipe Balbi @ 2019-09-04 7:46 UTC (permalink / raw)
To: Jacky.Cao; +Cc: Greg KH, linux-usb, Kernel development list, Kento.A.Kobayashi
Hi,
On Wed, Sep 4, 2019 at 9:47 AM <Jacky.Cao@sony.com> wrote:
>
> The power budget for SuperSpeed mode should be 900 mA
>
> according to USB3.0 specification, so set the power
>
> budget to 900 mA for dummy_start_ss which is only used
>
> for SuperSpeed mode.
>
>
>
> If the max power consumption of SuperSpeed device is
>
> larger than 500 mA, insufficient available bus power
>
> error happens in usb_choose_configuration function
>
> when the device connects to dummy hcd.
>
>
>
> Signed-off-by: Jacky Cao <Jacky.Cao@sony.com>
You must send plain/text emails. I'm not receiving this via the
mailing list. Please, fix your
email client or use git send-email
--
balbi
^ permalink raw reply [flat|nested] 12+ messages in thread
* RE: [PATCH] USB: dummy-hcd: fix power budget for SuperSpeed mode
2019-09-04 7:46 ` Felipe Balbi
@ 2019-09-04 7:54 ` Jacky.Cao
0 siblings, 0 replies; 12+ messages in thread
From: Jacky.Cao @ 2019-09-04 7:54 UTC (permalink / raw)
To: balbi; +Cc: gregkh, linux-usb, linux-kernel, Kento.A.Kobayashi, Jacky.Cao
Hi
>You must send plain/text emails. I'm not receiving this via the mailing list. Please, fix your email client or use git send-email
Thank you for your information.
I resend mail with text format, would you kind confirm the patch, thank you.
Best Regards
Jacky
-----Original Message-----
From: Felipe Balbi <balbi@kernel.org>
Sent: Wednesday, September 4, 2019 3:47 PM
To: Cao, Jacky <Jacky.Cao@sony.com>
Cc: Greg KH <gregkh@linuxfoundation.org>; linux-usb@vger.kernel.org; Kernel development list <linux-kernel@vger.kernel.org>; Kobayashi, Kento (Sony) <Kento.A.Kobayashi@sony.com>
Subject: Re: [PATCH] USB: dummy-hcd: fix power budget for SuperSpeed mode
Hi,
On Wed, Sep 4, 2019 at 9:47 AM <Jacky.Cao@sony.com> wrote:
>
> The power budget for SuperSpeed mode should be 900 mA
>
> according to USB3.0 specification, so set the power
>
> budget to 900 mA for dummy_start_ss which is only used
>
> for SuperSpeed mode.
>
>
>
> If the max power consumption of SuperSpeed device is
>
> larger than 500 mA, insufficient available bus power
>
> error happens in usb_choose_configuration function
>
> when the device connects to dummy hcd.
>
>
>
> Signed-off-by: Jacky Cao <Jacky.Cao@sony.com>
You must send plain/text emails. I'm not receiving this via the mailing list. Please, fix your email client or use git send-email
--
balbi
^ permalink raw reply [flat|nested] 12+ messages in thread
[parent not found: <16EA1F625E922C43B00B9D8225022050086ECF6A@APYOKXMS108.ap.sony.com>]
end of thread, other threads:[~2019-09-05 4:18 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-04 7:52 [PATCH] USB: dummy-hcd: fix power budget for SuperSpeed mode Jacky.Cao
2019-09-04 7:54 ` Felipe Balbi
2019-09-04 7:58 ` Greg KH
2019-09-04 8:52 ` Jacky.Cao
2019-09-04 10:01 ` Greg KH
2019-09-04 14:21 ` Alan Stern
2019-09-05 4:18 ` Jacky.Cao
[not found] <16EA1F625E922C43B00B9D82250220500871C7D7@APYOKXMS108.ap.sony.com>
2019-09-04 7:46 ` Felipe Balbi
2019-09-04 7:54 ` Jacky.Cao
[not found] <16EA1F625E922C43B00B9D8225022050086ECF6A@APYOKXMS108.ap.sony.com>
[not found] ` <16EA1F625E922C43B00B9D8225022050086F86B4@APYOKXMS108.ap.sony.com>
2019-09-04 6:12 ` Kobayashi, Kento (Sony)
2019-09-04 6:19 ` Felipe Balbi
2019-09-04 6:57 ` Kobayashi, Kento (Sony)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).