Hi,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[cannot apply to v5.3-rc7 next-20190903]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/richard-gong-linux-intel-com/add-Intel-Stratix10-remote-system-update-driver/20190904-072434
config: arm64-allyesconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=arm64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/firmware/stratix10-rsu.c:443:4: error: 'struct device_driver' has no member named 'dev_groups'; did you mean 'groups'?
      .dev_groups = rsu_groups,
       ^~~~~~~~~~
       groups
>> drivers/firmware/stratix10-rsu.c:443:17: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
      .dev_groups = rsu_groups,
                    ^~~~~~~~~~
   drivers/firmware/stratix10-rsu.c:443:17: note: (near initialization for 'stratix10_rsu_driver.driver.bus')
   cc1: some warnings being treated as errors

vim +443 drivers/firmware/stratix10-rsu.c

   437	
   438	static struct platform_driver stratix10_rsu_driver = {
   439		.probe = stratix10_rsu_probe,
   440		.remove = stratix10_rsu_remove,
   441		.driver = {
   442			.name = "stratix10-rsu",
 > 443			.dev_groups = rsu_groups,
   444		},
   445	};
   446	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation