From: Peter Zijlstra <peterz@infradead.org>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Randy Dunlap <rdunlap@infradead.org>,
Borislav Petkov <bp@alien8.de>, Juergen Gross <jgross@suse.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Stefano Stabellini <sstabellini@kernel.org>,
x86@kernel.org, linux-kernel@vger.kernel.org,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH -tip 0/2] x86: Prohibit kprobes on XEN_EMULATE_PREFIX
Date: Wed, 4 Sep 2019 14:02:32 +0200 [thread overview]
Message-ID: <20190904120232.GH2349@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <156759754770.24473.11832897710080799131.stgit@devnote2>
On Wed, Sep 04, 2019 at 08:45:47PM +0900, Masami Hiramatsu wrote:
> Hi,
>
> These patches allow x86 instruction decoder to decode
> xen-cpuid which has XEN_EMULATE_PREFIX, and prohibit
> kprobes to probe on it.
>
> Josh reported that the objtool can not decode such special
> prefixed instructions, and I found that we also have to
> prohibit kprobes to probe on such instruction.
>
> This series can be applied on -tip master branch which
> has merged Josh's objtool/perf sharing common x86 insn
> decoder series.
>
>
> Thank you,
>
> ---
>
> Masami Hiramatsu (2):
> x86: xen: insn: Decode XEN_EMULATE_PREFIX correctly
> x86: kprobes: Prohibit probing on instruction which has Xen prefix
>
>
> arch/x86/include/asm/insn.h | 2 +
> arch/x86/include/asm/xen/interface.h | 7 ++++-
> arch/x86/include/asm/xen/prefix.h | 10 +++++++
> arch/x86/kernel/kprobes/core.c | 4 +++
> arch/x86/lib/insn.c | 43 +++++++++++++++++++++++++++++++
> tools/arch/x86/include/asm/insn.h | 2 +
> tools/arch/x86/include/asm/xen/prefix.h | 10 +++++++
> tools/arch/x86/lib/insn.c | 43 +++++++++++++++++++++++++++++++
> tools/objtool/sync-check.sh | 3 +-
> 9 files changed, 121 insertions(+), 3 deletions(-)
> create mode 100644 arch/x86/include/asm/xen/prefix.h
> create mode 100644 tools/arch/x86/include/asm/xen/prefix.h
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
prev parent reply other threads:[~2019-09-04 12:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-04 11:45 [PATCH -tip 0/2] x86: Prohibit kprobes on XEN_EMULATE_PREFIX Masami Hiramatsu
2019-09-04 11:45 ` [PATCH -tip 1/2] x86: xen: insn: Decode XEN_EMULATE_PREFIX correctly Masami Hiramatsu
2019-09-04 11:46 ` [PATCH -tip 2/2] x86: kprobes: Prohibit probing on instruction which has Xen prefix Masami Hiramatsu
2019-09-04 11:54 ` [Xen-devel] [PATCH -tip 0/2] x86: Prohibit kprobes on XEN_EMULATE_PREFIX Andrew Cooper
2019-09-05 1:49 ` Masami Hiramatsu
2019-09-05 7:54 ` Andrew Cooper
2019-09-05 8:26 ` Peter Zijlstra
2019-09-05 8:53 ` Andrew Cooper
2019-09-05 9:26 ` Peter Zijlstra
2019-09-05 9:38 ` Andrew Cooper
2019-09-05 12:49 ` [OT] " Masami Hiramatsu
2019-09-05 11:32 ` Masami Hiramatsu
2019-09-05 13:09 ` Masami Hiramatsu
2019-09-05 13:31 ` Andrew Cooper
2019-09-05 16:12 ` Masami Hiramatsu
2019-09-04 12:02 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190904120232.GH2349@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=jgross@suse.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=rdunlap@infradead.org \
--cc=sstabellini@kernel.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).