From: Lee Jones <lee.jones@linaro.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: agross@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com,
bjorn.andersson@linaro.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/1] arm64: dts: qcom: Add Lenovo Yoga C630
Date: Wed, 4 Sep 2019 13:08:55 +0100 [thread overview]
Message-ID: <20190904120855.GJ26880@dell> (raw)
In-Reply-To: <20190904115234.GV2672@vkoul-mobl>
On Wed, 04 Sep 2019, Vinod Koul wrote:
> On 04-09-19, 12:39, Lee Jones wrote:
> > --- a/arch/arm64/boot/dts/qcom/Makefile
> > +++ b/arch/arm64/boot/dts/qcom/Makefile
> > @@ -12,5 +12,6 @@ dtb-$(CONFIG_ARCH_QCOM) += sdm845-cheza-r2.dtb
> > dtb-$(CONFIG_ARCH_QCOM) += sdm845-cheza-r3.dtb
> > dtb-$(CONFIG_ARCH_QCOM) += sdm845-db845c.dtb
> > dtb-$(CONFIG_ARCH_QCOM) += sdm845-mtp.dtb
> > +dtb-$(CONFIG_ARCH_QCOM) += sdm850-lenovo-yoga-c630.dtb
>
> Can we keep this sorted, so before mtp.
Look closer. :)
> > dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-1000.dtb
> > dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-4000.dtb
> > diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> > new file mode 100644
> > index 000000000000..ad160c718b33
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> > @@ -0,0 +1,454 @@
> > +// SPDX-License-Identifier: GPL-2.0
>
> Are we going to make this dual? or BSD..
This patches the DTS files already in this directory.
> > +&apps_rsc {
> > + pm8998-rpmh-regulators {
> > + compatible = "qcom,pm8998-rpmh-regulators";
> > + qcom,pmic-id = "a";
> > +
> > + vdd-l2-l8-l17-supply = <&vreg_s3a_1p35>;
> > + vdd-l7-l12-l14-l15-supply = <&vreg_s5a_2p04>;
> > +
> > + vreg_s2a_1p125: smps2 {
> > + };
> > +
> > + vreg_s3a_1p35: smps3 {
> > + regulator-min-microvolt = <1352000>;
> > + regulator-max-microvolt = <1352000>;
> > + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> > + };
> > +
> > + vreg_s4a_1p8: smps4 {
> > + regulator-min-microvolt = <1800000>;
> > + regulator-max-microvolt = <1800000>;
> > + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> > + };
> > +
> > + vreg_s5a_2p04: smps5 {
> > + regulator-min-microvolt = <2040000>;
> > + regulator-max-microvolt = <2040000>;
> > + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> > + };
> > +
> > + vreg_s7a_1p025: smps7 {
>
> Any reason why we dont specify the mode and min/max voltage for this
> and few others below..?
Might have to ask Bjorn that one.
> > +&i2c1 {
> > + status = "okay";
> > + clock-frequency = <400000>;
> > + qcom,geni-se-fifo;
> > +
> > + battery@70 {
> > + compatible = "some,battery";
>
> some,battery ..?
Good spot. This the battery level/AC detection driver that isn't
upstream yet. Will remove.
> > +&qup_i2c12_default {
>
> Please move the qup nodes up so that nodes are sorted alphabetically
Sure.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2019-09-04 12:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-04 11:39 [PATCH v2 1/1] arm64: dts: qcom: Add Lenovo Yoga C630 Lee Jones
2019-09-04 11:52 ` Vinod Koul
2019-09-04 12:08 ` Lee Jones [this message]
2019-09-04 20:43 ` Bjorn Andersson
2019-09-05 8:28 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190904120855.GJ26880@dell \
--to=lee.jones@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).