linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Joe Perches <joe@perches.com>
Cc: Petr Mladek <pmladek@suse.com>,
	linux-kernel@vger.kernel.org, rafael@kernel.org,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	linux-acpi@vger.kernel.org, devicetree@vger.kernel.org,
	Rob Herring <robh@kernel.org>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>
Subject: Re: [PATCH v5 00/11] Device property improvements, add %pfw format specifier
Date: Wed, 4 Sep 2019 19:04:16 +0300	[thread overview]
Message-ID: <20190904160416.GV5475@paasikivi.fi.intel.com> (raw)
In-Reply-To: <be9cd5d933486de9cf88a1550c2020c56348670d.camel@perches.com>

Hi Joe,

On Tue, Sep 03, 2019 at 02:38:48AM -0700, Joe Perches wrote:
> On Mon, 2019-09-02 at 16:57 +0300, Sakari Ailus wrote:
> > Hi all,
> > 
> > This set adds functionality into the device property API (counting a
> > node's parents as well as obtaining its name) in order to support printing
> > fwnode names using a new conversion specifier "%pfw". The names that are
> > produced are equivalent to its OF counterpart "%pOF" on OF systems for the
> > two supported modifiers ("f" and "P").
> > 
> > Printing a node's name is something that's been available on OF for a long
> > time and if something is converted to device property API (such as the
> > V4L2 fwnode framework) it always got removed of a nice feature that was
> > sometimes essential in debugging. With this set, that no longer is the
> > case.
> 
> Doesn't this still have dependencies on removing all
> existing %p[fF] uses?
> 
> In Linus' tree:
> 
> tools/lib/traceevent/Documentation/libtraceevent-func_apis.txt:or events have "%pF" or "%pS" parameter in its format string. It is common to
> tools/lib/traceevent/event-parse.c:             if (asprintf(&format, "%%pf: (NO FORMAT FOUND at %llx)\n", addr) < 0)
> tools/lib/traceevent/event-parse.c:     if (asprintf(&format, "%s: %s", "%pf", printk->printk) < 0)
> 
> And these in -next:
> 
> drivers/scsi/lpfc/lpfc_hbadisc.c:                                        "3185 FIND node filter %pf DID "
> drivers/scsi/lpfc/lpfc_hbadisc.c:                        "3186 FIND node filter %pf NOT FOUND.\n", filter);
> drivers/scsi/lpfc/lpfc_sli.c:                           "(%d):0307 Mailbox cmd x%x (x%x/x%x) Cmpl %pf "

Thanks for bringing these up.

I'll submit patches to address both.

-- 
Kind regards,

Sakari Ailus
sakari.ailus@linux.intel.com

      reply	other threads:[~2019-09-04 16:04 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-02 13:57 [PATCH v5 00/11] Device property improvements, add %pfw format specifier Sakari Ailus
2019-09-02 13:57 ` [PATCH v5 01/11] software node: Get reference to parent swnode in get_parent op Sakari Ailus
2019-09-02 13:57 ` [PATCH v5 02/11] software node: Make argument to to_software_node const Sakari Ailus
2019-09-02 13:57 ` [PATCH v5 03/11] device property: Move fwnode_get_parent() up Sakari Ailus
2019-09-02 13:57 ` [PATCH v5 04/11] device property: Add functions for accessing node's parents Sakari Ailus
2019-09-02 13:57 ` [PATCH v5 05/11] device property: Add fwnode_get_name for returning the name of a node Sakari Ailus
2019-09-03 10:10   ` Heikki Krogerus
2019-09-03 11:24     ` Sakari Ailus
2019-09-02 13:57 ` [PATCH v5 06/11] device property: Add a function to obtain a node's prefix Sakari Ailus
2019-09-02 13:57 ` [PATCH v5 07/11] lib/vsprintf: Remove support for %pF and %pf in favour of %pS and %ps Sakari Ailus
2019-09-02 13:57 ` [PATCH v5 08/11] lib/vsprintf: Make use of fwnode API to obtain node names and separators Sakari Ailus
2019-09-02 13:57 ` [PATCH v5 09/11] lib/vsprintf: OF nodes are first and foremost, struct device_nodes Sakari Ailus
2019-09-03  8:52   ` Petr Mladek
2019-09-03  9:28     ` Petr Mladek
2019-09-03 11:28       ` Andy Shevchenko
2019-09-06  7:04         ` Sakari Ailus
2019-09-02 13:57 ` [PATCH v5 10/11] lib/vsprintf: Add %pfw conversion specifier for printing fwnode names Sakari Ailus
2019-09-02 13:57 ` [PATCH v5 11/11] lib/test_printf: Add tests for %pfw printk modifier Sakari Ailus
2019-09-02 16:13   ` Andy Shevchenko
2019-09-04 16:10     ` Sakari Ailus
2019-09-04 17:22       ` Andy Shevchenko
2019-09-06  7:00         ` Sakari Ailus
2019-09-03  9:38 ` [PATCH v5 00/11] Device property improvements, add %pfw format specifier Joe Perches
2019-09-04 16:04   ` Sakari Ailus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190904160416.GV5475@paasikivi.fi.intel.com \
    --to=sakari.ailus@linux.intel.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=joe@perches.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmladek@suse.com \
    --cc=rafael@kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).