From: Vinod Koul <vkoul@kernel.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
tiwai@suse.de, broonie@kernel.org, gregkh@linuxfoundation.org,
jank@cadence.com, srinivas.kandagatla@linaro.org,
slawomir.blauciak@intel.com,
Sanyog Kale <sanyog.r.kale@intel.com>
Subject: Re: [alsa-devel] [PATCH 2/6] soundwire: cadence_master: add hw_reset capability in debugfs
Date: Wed, 4 Sep 2019 22:19:26 +0530 [thread overview]
Message-ID: <20190904164926.GA2672@vkoul-mobl> (raw)
In-Reply-To: <71411347-93cf-2617-4edd-f6b401fe7a9b@linux.intel.com>
On 04-09-19, 08:18, Pierre-Louis Bossart wrote:
> On 9/4/19 2:13 AM, Vinod Koul wrote:
> > On 13-08-19, 16:32, Pierre-Louis Bossart wrote:
> > > Provide debugfs capability to kick link and devices into hard-reset
> > > (as defined by MIPI). This capability is really useful when some
> > > devices are no longer responsive and/or to check the software handling
> > > of resynchronization.
> > >
> > > Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> > > ---
> > > drivers/soundwire/cadence_master.c | 20 ++++++++++++++++++++
> > > 1 file changed, 20 insertions(+)
> > >
> > > diff --git a/drivers/soundwire/cadence_master.c b/drivers/soundwire/cadence_master.c
> > > index 046622e4b264..bd58d80ff636 100644
> > > --- a/drivers/soundwire/cadence_master.c
> > > +++ b/drivers/soundwire/cadence_master.c
> > > @@ -340,6 +340,23 @@ static int cdns_reg_show(struct seq_file *s, void *data)
> > > }
> > > DEFINE_SHOW_ATTRIBUTE(cdns_reg);
> > > +static int cdns_hw_reset(void *data, u64 value)
> > > +{
> > > + struct sdw_cdns *cdns = data;
> > > + int ret;
> > > +
> > > + if (value != 1)
> > > + return 0;
> >
> > Should this not be EINVAL to indicate invalid value passed?
>
> Maybe. I must admit I don't know what -EINVAL would do, this is used for
> debugfs so it's not clear to me if the user will see a difference?
Well user should see "write error: Invalid argument" when he writes
anything other than valid values :)
--
~Vinod
next prev parent reply other threads:[~2019-09-04 16:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-13 21:32 [PATCH 0/6] soundwire: inits and PM additions for 5.4 Pierre-Louis Bossart
2019-08-13 21:32 ` [PATCH 1/6] soundwire: fix startup sequence for Intel/Cadence Pierre-Louis Bossart
2019-09-04 7:11 ` Vinod Koul
2019-09-04 13:16 ` [alsa-devel] " Pierre-Louis Bossart
2019-09-16 18:14 ` Pierre-Louis Bossart
2019-08-13 21:32 ` [PATCH 2/6] soundwire: cadence_master: add hw_reset capability in debugfs Pierre-Louis Bossart
2019-09-04 7:13 ` Vinod Koul
2019-09-04 13:18 ` [alsa-devel] " Pierre-Louis Bossart
2019-09-04 16:49 ` Vinod Koul [this message]
2019-09-04 17:43 ` Pierre-Louis Bossart
2019-08-13 21:32 ` [PATCH 3/6] soundwire: intel: add helper for initialization Pierre-Louis Bossart
2019-08-13 21:32 ` [PATCH 4/6] soundwire: intel: Add basic power management support Pierre-Louis Bossart
2019-08-13 21:32 ` [PATCH 5/6] soundwire: cadence_master: make clock stop exit configurable on init Pierre-Louis Bossart
2019-08-13 21:32 ` [PATCH 6/6] soundwire: intel: add pm_runtime support Pierre-Louis Bossart
2019-08-21 19:23 ` [alsa-devel] [PATCH 0/6] soundwire: inits and PM additions for 5.4 Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190904164926.GA2672@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jank@cadence.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=sanyog.r.kale@intel.com \
--cc=slawomir.blauciak@intel.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).