From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33312C3A5A8 for ; Wed, 4 Sep 2019 18:02:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0ADBD233FF for ; Wed, 4 Sep 2019 18:02:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567620165; bh=1RYvOBwHtQajG5Il0JH6xNqFr/+oHkRE2seaRdexZtc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=0dvUmiEqd9hkqH9PYHWqn0Qp83wlXiVEpLq+za214D17/CL7dNV/wUra8NGNG6diP zjlcUZMmsgPr3nk9D1i0Ox902KYmmHF+AiRsg5ud0aaBwBxUnh7kzv/hsgJqT0KDba mQTa83ePLk7lubtsuk2xtpXfFMb2DR+CO2JsPnAI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388812AbfIDSCo (ORCPT ); Wed, 4 Sep 2019 14:02:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:42756 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388800AbfIDSCl (ORCPT ); Wed, 4 Sep 2019 14:02:41 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AE45D208E4; Wed, 4 Sep 2019 18:02:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567620161; bh=1RYvOBwHtQajG5Il0JH6xNqFr/+oHkRE2seaRdexZtc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vw3cRvcBS7fbY1UuTaRlHtcca3zUpVJ4hzao3azUVNpak1Dn/N3x/sM9Ik6qjB4fy fEp5TZsLXPZTLCivrviqeBTed3jknVyHZUhhsbgn7gSX9/bGGZejrIWi4yGwnIxxlI LPaXPXzZ/mT6GHNFQK7oM5zy5P6ofdtsOipCLSkA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Tomi Valkeinen , Andrzej Hajda , Sasha Levin Subject: [PATCH 4.14 13/57] drm/bridge: tfp410: fix memleak in get_modes() Date: Wed, 4 Sep 2019 19:53:41 +0200 Message-Id: <20190904175303.217813422@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20190904175301.777414715@linuxfoundation.org> References: <20190904175301.777414715@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit c08f99c39083ab55a9c93b3e93cef48711294dad ] We don't free the edid blob allocated by the call to drm_get_edid(), causing a memleak. Fix this by calling kfree(edid) at the end of the get_modes(). Signed-off-by: Tomi Valkeinen Signed-off-by: Andrzej Hajda Link: https://patchwork.freedesktop.org/patch/msgid/20190610135739.6077-1-tomi.valkeinen@ti.com Signed-off-by: Sasha Levin --- drivers/gpu/drm/bridge/ti-tfp410.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c b/drivers/gpu/drm/bridge/ti-tfp410.c index acb857030951a..1bb01905be8e3 100644 --- a/drivers/gpu/drm/bridge/ti-tfp410.c +++ b/drivers/gpu/drm/bridge/ti-tfp410.c @@ -64,7 +64,12 @@ static int tfp410_get_modes(struct drm_connector *connector) drm_mode_connector_update_edid_property(connector, edid); - return drm_add_edid_modes(connector, edid); + ret = drm_add_edid_modes(connector, edid); + + kfree(edid); + + return ret; + fallback: /* No EDID, fallback on the XGA standard modes */ ret = drm_add_modes_noedid(connector, 1920, 1200); -- 2.20.1