From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=FROM_EXCESS_BASE64, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFD10C3A5A8 for ; Wed, 4 Sep 2019 18:35:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B6FD220882 for ; Wed, 4 Sep 2019 18:35:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733215AbfIDSfx (ORCPT ); Wed, 4 Sep 2019 14:35:53 -0400 Received: from mx2.suse.de ([195.135.220.15]:51126 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1732177AbfIDSfx (ORCPT ); Wed, 4 Sep 2019 14:35:53 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 30F66AC0C; Wed, 4 Sep 2019 18:35:52 +0000 (UTC) Date: Wed, 4 Sep 2019 20:35:51 +0200 From: Michal =?UTF-8?B?U3VjaMOhbmVr?= To: Hari Bathini Cc: linuxppc-dev@lists.ozlabs.org, Yangtao Li , Mahesh Salgaonkar , linux-kernel@vger.kernel.org, Paul Mackerras , Hari Bathini , Thomas Gleixner Subject: Re: [PATCH v2] powerpc/fadump: when fadump is supported register the fadump sysfs files. Message-ID: <20190904203551.5b06abb6@naga> In-Reply-To: <15be95b0-4cb2-1cf1-2fc1-ec313b9aa6f0@linux.ibm.com> References: <20190828172742.18378-1-msuchanek@suse.de> <15be95b0-4cb2-1cf1-2fc1-ec313b9aa6f0@linux.ibm.com> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 29 Aug 2019 10:58:16 +0530 Hari Bathini wrote: > On 28/08/19 10:57 PM, Michal Suchanek wrote: > > Currently it is not possible to distinguish the case when fadump is > > supported by firmware and disabled in kernel and completely unsupported > > using the kernel sysfs interface. User can investigate the devicetree > > but it is more reasonable to provide sysfs files in case we get some > > fadumpv2 in the future. > > > > With this patch sysfs files are available whenever fadump is supported > > by firmware. > > > > Signed-off-by: Michal Suchanek > > --- > > [...] > > > - if (!fw_dump.fadump_supported) { > > + if (!fw_dump.fadump_supported && fw_dump.fadump_enabled) { > > printk(KERN_ERR "Firmware-assisted dump is not supported on" > > " this hardware\n"); > > - return 0; > > } > > The above hunk is redundant with similar message already logged during > early boot in fadump_reserve_mem() function. I am not strongly against > this though. So... I see this: [ 0.000000] debug: ignoring loglevel setting. [ 0.000000] Firmware-assisted dump is not supported on this hardware [ 0.000000] Reserving 256MB of memory at 128MB for crashkernel (System RAM: 8192MB) [ 0.000000] Allocated 5832704 bytes for 2048 pacas at c000000007a80000 [ 0.000000] Page sizes from device-tree: [ 0.000000] base_shift=12: shift=12, sllp=0x0000, avpnm=0x00000000, tlbiel=1, penc=0 [ 0.000000] base_shift=16: shift=16, sllp=0x0110, avpnm=0x00000000, tlbiel=1, penc=1 [ 0.000000] Page orders: linear mapping = 16, virtual = 16, io = 16, vmemmap = 16 [ 0.000000] Using 1TB segments [ 0.000000] Initializing hash mmu with SLB Clearly the second message is logged from the above code. The duplicate is capitalized: "Firmware-Assisted Dump is not supported on this hardware" and I don't see it logged. So if anything is duplicate that should be removed it is the message in fadump_reserve_mem(). It is not clear why that one is not seen, though. Thanks Michal