From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Oleg Nesterov <oleg@redhat.com>, Ingo Molnar <mingo@kernel.org>,
Kees Cook <keescook@chromium.org>
Subject: [patch 3/6] posix-cpu-timers: Restrict timer_create() permissions
Date: Thu, 05 Sep 2019 14:03:42 +0200 [thread overview]
Message-ID: <20190905120539.888798188@linutronix.de> (raw)
In-Reply-To: 20190905120339.561100423@linutronix.de
Right now there is no restriction at all to attach a Posix CPU timer to any
process in the system. Per thread CPU timers are limited to be created by
threads in the same thread group.
Timers can be used to observe activity of tasks and also impose overhead on
the process to which they are attached because that process needs to do the
fine grained CPU time accounting.
Limit the ability to attach timers to a process by checking whether the
task which is creating the timer has permissions to attach ptrace on the
target process.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
kernel/time/posix-cpu-timers.c | 18 +++++++++++++++++-
1 file changed, 17 insertions(+), 1 deletion(-)
--- a/kernel/time/posix-cpu-timers.c
+++ b/kernel/time/posix-cpu-timers.c
@@ -6,6 +6,7 @@
#include <linux/sched/signal.h>
#include <linux/sched/cputime.h>
#include <linux/posix-timers.h>
+#include <linux/ptrace.h>
#include <linux/errno.h>
#include <linux/math64.h>
#include <linux/uaccess.h>
@@ -78,7 +79,22 @@ static struct task_struct *lookup_task(c
/*
* For processes require that p is group leader.
*/
- return has_group_leader_pid(p) ? p : NULL;
+ if (!has_group_leader_pid(p))
+ return NULL;
+
+ /*
+ * Avoid the ptrace overhead when this is current's process
+ */
+ if (same_thread_group(p, current))
+ return p;
+
+ /*
+ * Creating timers on processes which cannot be ptraced is not
+ * permitted:
+ */
+ if (!ptrace_may_access(p, PTRACE_MODE_ATTACH_REALCREDS))
+ return NULL;
+ return p;
}
static struct task_struct *__get_task_for_clock(const clockid_t clock,
next prev parent reply other threads:[~2019-09-05 12:12 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 12:03 [patch 0/6] posix-cpu-timers: Fallout fixes and permission tightening Thomas Gleixner
2019-09-05 12:03 ` [patch 1/6] posix-cpu-timers: Always clear head pointer on dequeue Thomas Gleixner
2019-09-05 15:49 ` Frederic Weisbecker
2019-09-05 12:03 ` [patch 2/6] posix-cpu-timers: Fix permission check regression Thomas Gleixner
2019-09-05 17:31 ` Frederic Weisbecker
2019-09-05 18:55 ` Thomas Gleixner
2019-09-05 21:15 ` [patch V2 " Thomas Gleixner
2019-09-09 15:13 ` Frederic Weisbecker
2019-09-10 11:18 ` [tip: timers/core] " tip-bot2 for Thomas Gleixner
2019-09-05 12:03 ` Thomas Gleixner [this message]
2019-09-21 0:44 ` [patch 3/6] posix-cpu-timers: Restrict timer_create() permissions Frederic Weisbecker
2019-09-05 12:03 ` [patch 4/6] posix-cpu-timers: Restrict clock_gettime() permissions Thomas Gleixner
2019-09-23 13:39 ` Frederic Weisbecker
2019-09-05 12:03 ` [patch 5/6] posix-cpu-timers: Sanitize thread clock permissions Thomas Gleixner
2019-09-05 12:21 ` Peter Zijlstra
2019-09-05 14:11 ` Thomas Gleixner
2019-09-23 14:03 ` Frederic Weisbecker
2019-09-05 12:03 ` [patch 6/6] posix-cpu-timers: Make PID=0 and PID=self handling consistent Thomas Gleixner
2019-09-23 14:13 ` Frederic Weisbecker
2019-09-23 14:17 ` Thomas Gleixner
2019-09-05 14:48 ` [patch 0/6] posix-cpu-timers: Fallout fixes and permission tightening Frederic Weisbecker
2019-09-05 14:57 ` Thomas Gleixner
2019-09-05 15:21 ` Frederic Weisbecker
2019-09-05 20:32 ` Kees Cook
2019-09-05 21:13 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190905120539.888798188@linutronix.de \
--to=tglx@linutronix.de \
--cc=fweisbec@gmail.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).