linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Saiyam Doshi <saiyamdoshi.in@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: peda@axentia.se, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: muxes: pca9541: use BIT() macro
Date: Thu, 5 Sep 2019 21:15:36 +0530	[thread overview]
Message-ID: <20190905154448.GA3378@SD> (raw)
In-Reply-To: <1d248333-abe9-cff8-ad29-d3b618643dc6@roeck-us.net>

On Thu, Sep 05, 2019 at 06:21:06AM -0700, Guenter Roeck wrote:
> linux/bitops.h should be included when using BIT().

It's included from linux/i2c-mux.h and it compiled successfully.
But if it's needed I'll update the patch and resend.

Just a question - What is the best practice in such case? Should the 
header included explicitly?

-Saiyam

  reply	other threads:[~2019-09-05 15:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-05 13:13 [PATCH] i2c: muxes: pca9541: use BIT() macro Saiyam Doshi
2019-09-05 13:21 ` Guenter Roeck
2019-09-05 15:45   ` Saiyam Doshi [this message]
2019-09-05 16:53     ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190905154448.GA3378@SD \
    --to=saiyamdoshi.in@gmail.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=peda@axentia.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).