From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17456C43331 for ; Fri, 6 Sep 2019 07:14:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E9B4B218DE for ; Fri, 6 Sep 2019 07:13:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391719AbfIFHN7 (ORCPT ); Fri, 6 Sep 2019 03:13:59 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:56458 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726115AbfIFHN6 (ORCPT ); Fri, 6 Sep 2019 03:13:58 -0400 Received: from localhost (unknown [88.214.187.128]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id E584E15163DE2; Fri, 6 Sep 2019 00:13:56 -0700 (PDT) Date: Fri, 06 Sep 2019 09:13:50 +0200 (CEST) Message-Id: <20190906.091350.2133455010162259391.davem@davemloft.net> To: enkechen@cisco.com Cc: kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, xe-linux-external@cisco.com Subject: Re: [PATCH] net: Remove the source address setting in connect() for UDP From: David Miller In-Reply-To: <20190906025437.613-1-enkechen@cisco.com> References: <20190906025437.613-1-enkechen@cisco.com> X-Mailer: Mew version 6.8 on Emacs 26.2 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 06 Sep 2019 00:13:58 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Enke Chen Date: Thu, 5 Sep 2019 19:54:37 -0700 > The connect() system call for a UDP socket is for setting the destination > address and port. But the current code mistakenly sets the source address > for the socket as well. Remove the source address setting in connect() for > UDP in this patch. Do you have any idea how many decades of precedence this behavior has and therefore how much you potentially will break userspace? This boat has sailed a long time ago I'm afraid.