From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AE2EC00307 for ; Fri, 6 Sep 2019 17:17:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4270720838 for ; Fri, 6 Sep 2019 17:17:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567790259; bh=/DJjKsuBIxo0lC+JYJbHfrEm34PU0CCmBYb4S4pNbSQ=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:List-ID: From; b=ydWarzqWeFBJH0jSw9HfXh+koHEkNTWCEau8J7kbQvSQd9xRR7fVk4nHkbk4hcNxB Ca4zQcRNdeJaddYsbPCcJ8Q1FxCNVauVgPlMMd5mqSn2DVTb9SuO4iYl19YJ8ujueP B7sKJ6QHkCyM1PR80HRL6lq6LFDOW+Ob2MJusHTA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406034AbfIFRRi (ORCPT ); Fri, 6 Sep 2019 13:17:38 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:33134 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404502AbfIFRRi (ORCPT ); Fri, 6 Sep 2019 13:17:38 -0400 Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x86HDR4t144070; Fri, 6 Sep 2019 13:16:41 -0400 Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 2uus1qy8gj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 06 Sep 2019 13:16:40 -0400 Received: from m0098396.ppops.net (m0098396.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.27/8.16.0.27) with SMTP id x86HDYQS144511; Fri, 6 Sep 2019 13:16:39 -0400 Received: from ppma05wdc.us.ibm.com (1b.90.2fa9.ip4.static.sl-reverse.com [169.47.144.27]) by mx0a-001b2d01.pphosted.com with ESMTP id 2uus1qy8fx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 06 Sep 2019 13:16:39 -0400 Received: from pps.filterd (ppma05wdc.us.ibm.com [127.0.0.1]) by ppma05wdc.us.ibm.com (8.16.0.27/8.16.0.27) with SMTP id x86HFU9i012063; Fri, 6 Sep 2019 17:16:38 GMT Received: from b01cxnp23034.gho.pok.ibm.com (b01cxnp23034.gho.pok.ibm.com [9.57.198.29]) by ppma05wdc.us.ibm.com with ESMTP id 2uu32utmf6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 06 Sep 2019 17:16:38 +0000 Received: from b01ledav003.gho.pok.ibm.com (b01ledav003.gho.pok.ibm.com [9.57.199.108]) by b01cxnp23034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x86HGcdQ48497114 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 6 Sep 2019 17:16:38 GMT Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 15941B2065; Fri, 6 Sep 2019 17:16:38 +0000 (GMT) Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DAA83B205F; Fri, 6 Sep 2019 17:16:37 +0000 (GMT) Received: from paulmck-ThinkPad-W541 (unknown [9.70.82.154]) by b01ledav003.gho.pok.ibm.com (Postfix) with ESMTP; Fri, 6 Sep 2019 17:16:37 +0000 (GMT) Received: by paulmck-ThinkPad-W541 (Postfix, from userid 1000) id 05E2C16C5AE5; Fri, 6 Sep 2019 10:16:47 -0700 (PDT) Date: Fri, 6 Sep 2019 10:16:47 -0700 From: "Paul E. McKenney" To: Joel Fernandes Cc: linux-kernel@vger.kernel.org, Andy Lutomirski , Bjorn Helgaas , Ingo Molnar , Josh Triplett , Lai Jiangshan , Mathieu Desnoyers , Petr Mladek , "Rafael J. Wysocki" , rcu@vger.kernel.org, Steven Rostedt , Yafang Shao Subject: Re: [PATCH -rcu dev 1/2] Revert b8c17e6664c4 ("rcu: Maintain special bits at bottom of ->dynticks counter") Message-ID: <20190906171646.GI4051@linux.ibm.com> Reply-To: paulmck@kernel.org References: <20190904101210.GM4125@linux.ibm.com> <20190904135420.GB240514@google.com> <20190904231308.GB4125@linux.ibm.com> <20190905153620.GG26466@google.com> <20190905164329.GT4125@linux.ibm.com> <20190906000137.GA224720@google.com> <20190906150806.GA11355@google.com> <20190906152144.GF4051@linux.ibm.com> <20190906152753.GA18734@linux.ibm.com> <20190906165751.GA40876@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190906165751.GA40876@google.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-09-06_07:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1034 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1909060183 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 06, 2019 at 12:57:51PM -0400, Joel Fernandes wrote: > On Fri, Sep 06, 2019 at 08:27:53AM -0700, Paul E. McKenney wrote: > > On Fri, Sep 06, 2019 at 08:21:44AM -0700, Paul E. McKenney wrote: > > > On Fri, Sep 06, 2019 at 11:08:06AM -0400, Joel Fernandes wrote: > > > > On Thu, Sep 05, 2019 at 08:01:37PM -0400, Joel Fernandes wrote: > > > > [snip] > > > > > > > > @@ -3004,7 +3007,7 @@ static int rcu_pending(void) > > > > > > > > return 0; > > > > > > > > > > > > > > > > /* Is the RCU core waiting for a quiescent state from this CPU? */ > > > > > > > > - if (rdp->core_needs_qs && !rdp->cpu_no_qs.b.norm) > > > > > > > > + if (READ_ONCE(rdp->core_needs_qs) && !rdp->cpu_no_qs.b.norm) > > > > > > > > return 1; > > > > > > > > > > > > > > > > /* Does this CPU have callbacks ready to invoke? */ > > > > > > > > @@ -3244,7 +3247,6 @@ int rcutree_prepare_cpu(unsigned int cpu) > > > > > > > > rdp->gp_seq = rnp->gp_seq; > > > > > > > > rdp->gp_seq_needed = rnp->gp_seq; > > > > > > > > rdp->cpu_no_qs.b.norm = true; > > > > > > > > - rdp->core_needs_qs = false; > > > > > > > > > > > > > > How about calling the new hint-clearing function here as well? Just for > > > > > > > robustness and consistency purposes? > > > > > > > > > > > > This and the next function are both called during a CPU-hotplug online > > > > > > operation, so there is little robustness or consistency to be had by > > > > > > doing it twice. > > > > > > > > > > Ok, sorry I missed you are clearing it below in the next function. That's > > > > > fine with me. > > > > > > > > > > This patch looks good to me and I am Ok with merging of these changes into > > > > > the original patch with my authorship as you mentioned. Or if you wanted to > > > > > be author, that's fine too :) > > > > > > > > Paul, does it make sense to clear these urgency hints in rcu_qs() as well? > > > > After all, we are clearing atleast one urgency hint there: the > > > > rcu_read_unlock_special::need_qs bit. > > Makes sense. > > > > We certainly don't want to turn off the scheduling-clock interrupt until > > > after the quiescent state has been reported to the RCU core. And it might > > > still be useful to have a heavy quiescent state because the grace-period > > > kthread can detect that. Just in case the CPU that just called rcu_qs() > > > is slow about actually reporting that quiescent state to the RCU core. > > > > Hmmm... Should ->need_qs ever be cleared from FQS to begin with? > > I did not see the FQS loop clearing ->need_qs in the rcu_read_unlock_special > union after looking for a few minutes. Could you clarify which path this? > > Or do you mean ->core_needs_qs? If so, I feel the FQS loop should clear it as > I think your patch does, since the FQS loop is essentially doing heavy-weight > RCU core processing right? > > Also, where does FQS loop clear rdp.cpu_no_qs? Shouldn't it clear that as > well for the dyntick-idle CPUs? Synchronization? Thanx, Paul