From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 488F3C00307 for ; Fri, 6 Sep 2019 18:25:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2517020578 for ; Fri, 6 Sep 2019 18:25:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="tgPNLCyt" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2395337AbfIFSZf (ORCPT ); Fri, 6 Sep 2019 14:25:35 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:34813 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388289AbfIFSZe (ORCPT ); Fri, 6 Sep 2019 14:25:34 -0400 Received: by mail-pf1-f193.google.com with SMTP id r12so5057592pfh.1 for ; Fri, 06 Sep 2019 11:25:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=hi4I00yzrvjyDfq4Sb0LtZ///vr5wch4QIwVVeeu58U=; b=tgPNLCytwqi6Eg7kgmztBs/cNpNh9cxkPtPcpl5lRVJoPELYoaUwQ8Mv9YiWOTwGw3 IzabFz5Bg5srMnqvFJ3uIt/IkEwDZktKRRfbIaTjZfIaVW6612RjMfe2d8YgKEELbgXS ghlp9nGO078teOa1dpUSBFq0kz9UYTvqT9Bh5pEbnq4/HtDVEUELnm0enHbVVbYiUny2 5fXqfXoMKFX6naNJRRmm1V2w1xubXFvNZtIJQSH5TD4O9+L4nKJWyd4a2p5Pyg89EuaN lPcLDOlfnHWx5N5AkcKJIRYPZzeSzZNnyOYT1eMGJkr6eRrDGLB7bqILDTeYo6aPqRiY B2eA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=hi4I00yzrvjyDfq4Sb0LtZ///vr5wch4QIwVVeeu58U=; b=D3UcUCExCQwiHnSee+srL0j1VCvaRI/y1S65ulkbeHuognQFQsPg9Oc4gtbJPQx/mT dqHP0LkPQVw5rhb2lDlplw6l9xvHNxAh1VcWn9q/BqRG04XBKVc7cZEVPIjgPJ0finp8 T2x/oorpOa+KZKXk+yUDEQ8TX7R0WmABSlE/qqczsv4Rd35MWu5AL57R9U6f335nqcxN rzpn2NKZlCawq0gefRM6PYcPG9MWuakw53tCiUEEE+oA466Wmk9RCCxZlpl+KaNjoK5S M1eWt7a2xBW+XC9FhZsGUGHMk6N2DNqa6rIzYh8pBvcukWPLQLFu5XjUCH/sW0XE3nhD 2aJw== X-Gm-Message-State: APjAAAU4m6jaVOAMSh4Flt3ZYTUlyJ7OZL+cYj9epKUNl0b69mKAXWeF bva1kV7aI0XZe+X4CQoouJxo+A== X-Google-Smtp-Source: APXvYqyeiG+qz99HWZk7tAxTHFq2pCo/5SMXlzP6RqwmzOV6EmB6TEiXu9iDoH0GK5MAewVwnReY8A== X-Received: by 2002:a65:62cd:: with SMTP id m13mr9076178pgv.437.1567794333735; Fri, 06 Sep 2019 11:25:33 -0700 (PDT) Received: from tuxbook-pro (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id j18sm7684471pfh.70.2019.09.06.11.25.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Sep 2019 11:25:33 -0700 (PDT) Date: Fri, 6 Sep 2019 11:25:30 -0700 From: Bjorn Andersson To: Stephen Boyd Cc: Jack Pham , Jorge Ramirez , robh@kernel.org, andy.gross@linaro.org, shawn.guo@linaro.org, gregkh@linuxfoundation.org, mark.rutland@arm.com, kishon@ti.com, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, khasim.mohammed@linaro.org Subject: Re: [PATCH v4 3/4] dt-bindings: Add Qualcomm USB SuperSpeed PHY bindings Message-ID: <20190906182530.GD11938@tuxbook-pro> References: <5d694878.1c69fb81.5f13b.ec4f@mx.google.com> <20190830164520.GK26807@tuxbook-pro> <5d696ad2.1c69fb81.977ea.39e5@mx.google.com> <20190903173924.GB9754@jackp-linux.qualcomm.com> <5d6edee5.1c69fb81.a3896.1d05@mx.google.com> <20190903233410.GQ26807@tuxbook-pro> <20190905175802.GA19599@jackp-linux.qualcomm.com> <5d71edf5.1c69fb81.1f307.fdd6@mx.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5d71edf5.1c69fb81.1f307.fdd6@mx.google.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 05 Sep 22:26 PDT 2019, Stephen Boyd wrote: > Quoting Jack Pham (2019-09-05 10:58:02) > > Hi Jorge, Bjorn, > > > > On Thu, Sep 05, 2019 at 09:18:57AM +0200, Jorge Ramirez wrote: > > > On 9/4/19 01:34, Bjorn Andersson wrote: > > > > On Tue 03 Sep 14:45 PDT 2019, Stephen Boyd wrote: > > > >> that would need an of_regulator_get() sort of API that can get the > > > >> regulator out of there? Or to make the connector into a struct device > > > >> that can get the regulator out per some generic connector driver and > > > >> then pass it through to the USB controller when it asks for it. Maybe > > > >> try to prototype that out? > > > >> > > > > > > > > The examples given in the DT bindings describes the connector as a child > > > > of a PMIC, with of_graph somehow tying it to the various inputs. But in > > > > these examples vbus is handled by implicitly inside the MFD, where > > > > extcon is informed about the plug event they toggle vbus as well. > > > > > > > > In our case we have a extcon-usb-gpio to detect mode, which per Jorge's > > > > proposal will trickle down to the PHY and become a regulator calls on > > > > either some external regulator or more typically one of the chargers in > > > > the system. > > > > Interesting you mention extcon-usb-gpio. I thought extcon at least from > > bindings perspective is passé now. Maybe this is what you need (just > > landed in usb-next): > > > > usb: common: add USB GPIO based connection detection driver > > https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/commit/?h=usb-next&id=4602f3bff2669012c1147eecfe74c121765f5c56 > > > > dt-bindings: usb: add binding for USB GPIO based connection detection driver > > https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/commit/?h=usb-next&id=f651c73e71f53f65e9846677d79d8e120452b59f > > > > Fortunately this new driver might check the right boxes for you: > > - usb connector binding > > - ID detect GPIO > > - vbus-supply regulator > > > > With that, I think you can also keep the connector subnode out of the > > SSPHY node well, and similarly get rid of the vbus toggle handling from > > the PHY driver. > > > > The big thing missing now is that this driver replaces extcon > > completely, so we'll need handling in dwc3/dwc3-qcom to retrieve the > > role switch state to know when host mode is entered. I saw this a while > > back but don't think it got picked up: > > > > https://patchwork.kernel.org/patch/10909981/ > > > > Yes this looks like the approach that should be taken. One question > though, is this a micro-b connector or a type-c connector on the board? > I thought it was a type-c, so then this USB gpio based connection driver > isn't an exact fit? > For this particular case it's a type c connector, but the port controller is operated completely passively (and there's no PD or DP involved), so the GPIO based approach seems like a good fit. Regards, Bjorn