From: David Miller <davem@davemloft.net>
To: colin.king@canonical.com
Cc: yisen.zhuang@huawei.com, salil.mehta@huawei.com,
lipeng321@huawei.com, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: hns3: make array spec_opcode static const, makes object smaller
Date: Sat, 07 Sep 2019 18:03:24 +0200 (CEST) [thread overview]
Message-ID: <20190907.180324.2086722384944546511.davem@davemloft.net> (raw)
In-Reply-To: <20190906112804.7812-1-colin.king@canonical.com>
From: Colin King <colin.king@canonical.com>
Date: Fri, 6 Sep 2019 12:28:04 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate the array spec_opcode on the stack but instead make it
> static const. Makes the object code smaller by 48 bytes.
>
> Before:
> text data bss dec hex filename
> 6914 1040 128 8082 1f92 hns3/hns3vf/hclgevf_cmd.o
>
> After:
> text data bss dec hex filename
> 6866 1040 128 8034 1f62 hns3/hns3vf/hclgevf_cmd.o
>
> (gcc version 9.2.1, amd64)
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied.
next prev parent reply other threads:[~2019-09-07 16:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-06 11:28 [PATCH] net: hns3: make array spec_opcode static const, makes object smaller Colin King
2019-09-07 16:03 ` David Miller [this message]
2021-08-19 11:58 Colin King
2021-08-19 12:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190907.180324.2086722384944546511.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lipeng321@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=salil.mehta@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).