From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DEE7C43331 for ; Sat, 7 Sep 2019 13:34:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1391721835 for ; Sat, 7 Sep 2019 13:34:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393160AbfIGNeW (ORCPT ); Sat, 7 Sep 2019 09:34:22 -0400 Received: from ms.lwn.net ([45.79.88.28]:42594 "EHLO ms.lwn.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731344AbfIGNeW (ORCPT ); Sat, 7 Sep 2019 09:34:22 -0400 Received: from lwn.net (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ms.lwn.net (Postfix) with ESMTPSA id 6B6A82BD; Sat, 7 Sep 2019 13:34:20 +0000 (UTC) Date: Sat, 7 Sep 2019 07:34:19 -0600 From: Jonathan Corbet To: Mauro Carvalho Chehab Cc: Linux Media Mailing List , Mauro Carvalho Chehab , Greg Kroah-Hartman , Joe Perches , linux-kernel@vger.kernel.org, Arnaldo Carvalho de Melo , Sven Eckelmann , Ingo Molnar , Thomas Gleixner , Doug Smythies , =?UTF-8?B?QXVyw6lsaWVu?= Cedeyn , Vincenzo Frascino , linux-doc@vger.kernel.org, "Rafael J. Wysocki" , Andrew Morton , Thierry Reding , Armijn Hemel , Jiri Olsa , Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= , Namhyung Kim , Peter Zijlstra , Federico Vaga , Allison Randal , Alexander Shishkin Subject: Re: [PATCH 0/6] Address issues with SPDX requirements and PEP-263 Message-ID: <20190907073419.6a88e318@lwn.net> In-Reply-To: References: Organization: LWN.net MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 5 Sep 2019 16:57:47 -0300 Mauro Carvalho Chehab wrote: > The description at Documentation/process/license-rules.rst is very strict > with regards to the position where the SPDX tags should be. > > In the past several developers and maintainers interpreted it on a > more permissive way, placing the SPDX header between lines 1 to 15, > with are the ones which the scripts/spdxcheck.py script verifies. > > However, recently, devs are becoming more strict about such > requirement and want it to strictly follow the rule, with states that > the SPDX rule should be at the first line ever on most files, and > at the second line for scripts. > > Well, for Python script, such requirement causes violation to PEP-263, > making regressions on scripts that contain encoding lines, as PEP-263 > also states about the same. > > This series addresses it. So I really don't want to be overly difficult here, but I would like to approach this from yet another angle... > Patches 1 to 3 fix some Python scripts that violates PEP-263; I just checked all of those scripts, and they are all just plain ASCII. So it really doesn't matter whether the environment defaults to UTF-8 or ASCII here. So, in other words, we really shouldn't need to define the encoding at all. This suggests to me that we're adding a bunch of complications that we don't necessarily need. What am I missing here? Educate me properly and I'll not try to stand in the way of all this... Thanks, jon