From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE087C4332F for ; Sun, 8 Sep 2019 10:03:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9CFB620863 for ; Sun, 8 Sep 2019 10:03:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="iJuH+yTF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728058AbfIHKDm (ORCPT ); Sun, 8 Sep 2019 06:03:42 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:47100 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728023AbfIHKDm (ORCPT ); Sun, 8 Sep 2019 06:03:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=VRngH9Tt6f5tjpW6Ayv7hzJ7nXQI6UyfmRniBoaIh7c=; b=iJuH+yTFQErKs399GoKdUJniH rdLj59hSS43GfWs2Vd8enOMGPQwJZ5pl5vfkJusuOGuEk/AQk3nQowGkuf+IGDjj0nzdr0UTu2huR t+ZovCxUaff5nGjtJWEYS2J6PAtNZI66+AqSOhvvST6faaar+0ZzbJzgCX18Oob2CiyRGF8x2Kilp YWtXCTW67f0X7bBc6R9HE22cnxJgFrTzqjFXF/xqi35rhRZoRvPTB9GWuMMO8cb6lzxIscENBNdV4 7UYegeMq1FAqGE9O5zdmVOLJAJ+lxNChcMwVgkPFjsQ7jrAwJlMQquCiRwxHa0mcPcqzz0lWDnrOL bLEL4E0pA==; Received: from willy by bombadil.infradead.org with local (Exim 4.92 #3 (Red Hat Linux)) id 1i6u2a-0004cU-F5; Sun, 08 Sep 2019 10:03:28 +0000 Date: Sun, 8 Sep 2019 03:03:28 -0700 From: Matthew Wilcox To: Thomas Gleixner Cc: Markus Heiser , Mauro Carvalho Chehab , Jonathan Corbet , Linux Media Mailing List , Mauro Carvalho Chehab , Greg Kroah-Hartman , Joe Perches , linux-kernel@vger.kernel.org, Arnaldo Carvalho de Melo , Sven Eckelmann , Ingo Molnar , Doug Smythies , =?iso-8859-1?Q?Aur=E9lien?= Cedeyn , Vincenzo Frascino , linux-doc@vger.kernel.org, "Rafael J. Wysocki" , Andrew Morton , Thierry Reding , Armijn Hemel , Jiri Olsa , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Namhyung Kim , Peter Zijlstra , Federico Vaga , Allison Randal , Alexander Shishkin , Shuah Khan Subject: Re: [PATCH 0/6] Address issues with SPDX requirements and PEP-263 Message-ID: <20190908100328.GB29434@bombadil.infradead.org> References: <20190907073419.6a88e318@lwn.net> <20190907132259.3199c8a2@coco.lan> <20190907150442.583b44c2@coco.lan> <686101df-f40c-916e-2730-353a3852cc84@darmarit.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Sep 07, 2019 at 11:17:22PM +0200, Thomas Gleixner wrote: > On Sat, 7 Sep 2019, Markus Heiser wrote: > > Am 07.09.19 um 20:04 schrieb Mauro Carvalho Chehab: > > > No idea. I would actually prefer to just remove the restriction, and let > > > the SPDX header to be anywhere inside the first comment block inside a > > > file [2]. > > > [2] I *suspect* that the restriction was added in order to make > > > ./scripts/spdxcheck.py to run faster and to avoid false positives. > > > Right now, if the maximum limit is removed (or set to a very high > > > value), there will be one false positive: > > Nope. The intention was to have a well define place and format instead of > everyone and his dog deciding to put it somewhere. SPDX is not intended to > replace the existing licensing mess with some other randomly placed and > formatted licensing mess. I find the current style quite unaesthetic: // SPDX-License-Identifier: GPL-2.0-only /* * linux/mm/memory.c * * Copyright (C) 1991, 1992, 1993, 1994 Linus Torvalds */ I'd much rather see /* * SPDX-License-Identifier: GPL-2.0-only * Copyright (C) 1991, 1992, 1993, 1994 Linus Torvalds */ but I appreciate the desire to force it to be on the first line if at all possible.