From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE783C4332F for ; Sun, 8 Sep 2019 12:43:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B8639218DE for ; Sun, 8 Sep 2019 12:43:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567946605; bh=Z3/hYNa9hLaR25pImy5L8T05rp//UxTQxjH0Rnzk0ok=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=eOzRHlGPooN8JIHGlcSv+QwnQgdMC4Hx/lxeECoPC2xQw7PJJtk8Kw6z//CuHUmdD CwheUWn5PKVOqlrmidUCM2oNhf4iNHEi+e0E28d0nN1jbqPV4ZnMWGd80x6CXDPX4W 5priAXmJSoVSa0DCm1gIBGztT3fASRilE51oZBlk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729440AbfIHMnV (ORCPT ); Sun, 8 Sep 2019 08:43:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:56996 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729384AbfIHMnS (ORCPT ); Sun, 8 Sep 2019 08:43:18 -0400 Received: from localhost (unknown [62.28.240.114]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 90B62218AE; Sun, 8 Sep 2019 12:43:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567946597; bh=Z3/hYNa9hLaR25pImy5L8T05rp//UxTQxjH0Rnzk0ok=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hfkr+MRfzqJwbdf3nGJ02374T0booPugc0LF/Wm8ju4CQWJWjlnPjBXYrns2efywb XrSWmBRBelOOPkF6FmeHoi2BMJKHeUplDjpGXsVs5eDX4Dz6eevDFNoXgktXlj7GR4 oZX0yokrNpbf6eF4tg6jab7s83zS62ldrAqIOETQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Wenwen Wang , "David S. Miller" , Sasha Levin Subject: [PATCH 4.4 06/23] cxgb4: fix a memory leak bug Date: Sun, 8 Sep 2019 13:41:41 +0100 Message-Id: <20190908121056.047922709@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20190908121052.898169328@linuxfoundation.org> References: <20190908121052.898169328@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit c554336efa9bbc28d6ec14efbee3c7d63c61a34f ] In blocked_fl_write(), 't' is not deallocated if bitmap_parse_user() fails, leading to a memory leak bug. To fix this issue, free t before returning the error. Signed-off-by: Wenwen Wang Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c index 4269944c5db53..129d6095749a4 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c @@ -2673,8 +2673,10 @@ static ssize_t blocked_fl_write(struct file *filp, const char __user *ubuf, return -ENOMEM; err = bitmap_parse_user(ubuf, count, t, adap->sge.egr_sz); - if (err) + if (err) { + kvfree(t); return err; + } bitmap_copy(adap->sge.blocked_fl, t, adap->sge.egr_sz); t4_free_mem(t); -- 2.20.1