From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA9E9C4332F for ; Sun, 8 Sep 2019 12:43:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BC8F1218AE for ; Sun, 8 Sep 2019 12:43:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567946583; bh=ekry1gRPG2taOM42WYlDVVGVCaymn+PoMA25piqGwJE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=0nc/ZIHnL2sAmHVlUV9jgyyHMW9s3XW1QmrcaCU07qof13GNfY4sCeOa7A+sEOV9Y FmYgpKe6pJbLuatXhtuwa6JixRrH+wDLb5HKbByLL7B+eZysbwu9c6sXmfqW9gAcmr axLMVX4rNKC9n/s99Pep3hWm+UIioEBMn5r7PLw0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729350AbfIHMnD (ORCPT ); Sun, 8 Sep 2019 08:43:03 -0400 Received: from mail.kernel.org ([198.145.29.99]:56516 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726329AbfIHMnB (ORCPT ); Sun, 8 Sep 2019 08:43:01 -0400 Received: from localhost (unknown [62.28.240.114]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B67422081B; Sun, 8 Sep 2019 12:43:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567946581; bh=ekry1gRPG2taOM42WYlDVVGVCaymn+PoMA25piqGwJE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=zs67MOy6Q8HC2Fw3TBPhCmp0anWQf0Ly7+K4Bf7fnQiGgSN3w898K06X16iSwGxwZ dd5IjxZ4IPKWyoCwcGSsJWKeBbl7kRyvN2z4giaOhsYogxCpA5/BehdUHAtTizlCfi 6lVnBEcGAaNL6NlILbO5MNDJIIdWPNNMOno8RYuU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Wenwen Wang , Leon Romanovsky , Doug Ledford , Sasha Levin Subject: [PATCH 4.4 13/23] IB/mlx4: Fix memory leaks Date: Sun, 8 Sep 2019 13:41:48 +0100 Message-Id: <20190908121058.697114215@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20190908121052.898169328@linuxfoundation.org> References: <20190908121052.898169328@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 5c1baaa82cea2c815a5180ded402a7cd455d1810 ] In mlx4_ib_alloc_pv_bufs(), 'tun_qp->tx_ring' is allocated through kcalloc(). However, it is not always deallocated in the following execution if an error occurs, leading to memory leaks. To fix this issue, free 'tun_qp->tx_ring' whenever an error occurs. Signed-off-by: Wenwen Wang Acked-by: Leon Romanovsky Link: https://lore.kernel.org/r/1566159781-4642-1-git-send-email-wenwen@cs.uga.edu Signed-off-by: Doug Ledford Signed-off-by: Sasha Levin --- drivers/infiniband/hw/mlx4/mad.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/infiniband/hw/mlx4/mad.c b/drivers/infiniband/hw/mlx4/mad.c index 199a9cdd0d12a..531c985f6fd71 100644 --- a/drivers/infiniband/hw/mlx4/mad.c +++ b/drivers/infiniband/hw/mlx4/mad.c @@ -1526,8 +1526,6 @@ tx_err: tx_buf_size, DMA_TO_DEVICE); kfree(tun_qp->tx_ring[i].buf.addr); } - kfree(tun_qp->tx_ring); - tun_qp->tx_ring = NULL; i = MLX4_NUM_TUNNEL_BUFS; err: while (i > 0) { @@ -1536,6 +1534,8 @@ err: rx_buf_size, DMA_FROM_DEVICE); kfree(tun_qp->ring[i].addr); } + kfree(tun_qp->tx_ring); + tun_qp->tx_ring = NULL; kfree(tun_qp->ring); tun_qp->ring = NULL; return -ENOMEM; -- 2.20.1