From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B1E0C433EF for ; Sun, 8 Sep 2019 12:47:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0FAE12190F for ; Sun, 8 Sep 2019 12:47:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567946866; bh=GSoye/YM6Rzkiq60yfP+e/AqbnEbrCA1QzAJqPhhZ1I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=nyQ6F5tWEW4oXlwrOow0XMj7F76+cM8XKhdvDFLC5aAlMuwllvJauP9bGp2OwHLqm DFTCzjnYMIwXynn4kaWn5xti4cBswyro/LrNtqGacah/iCi7jbh6N38NAvMmNqKy+t NSv4DAl0LT4ijcJGidQuEkdVSg22+QHFP9sGwjgM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730784AbfIHMrp (ORCPT ); Sun, 8 Sep 2019 08:47:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:36212 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730759AbfIHMrk (ORCPT ); Sun, 8 Sep 2019 08:47:40 -0400 Received: from localhost (unknown [62.28.240.114]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DF43F218AC; Sun, 8 Sep 2019 12:47:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567946860; bh=GSoye/YM6Rzkiq60yfP+e/AqbnEbrCA1QzAJqPhhZ1I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NoOMkTXsSMUuyCgdIVQ1cjiptedJw+8SBf8LP3NhQ4fjLfx0+3A0VhL7GirZPoLbi kCG/vPMPhHJ9InU6nKnXIEggJkwwOUmjyKjNI3+XJHzGOTz/Mgedd4aR1CcHUkS8ne TlX2xJeGyYrMPoVcBz1bdGKlwroX2xutQexyXiWc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Wenwen Wang , "David S. Miller" , Sasha Levin Subject: [PATCH 4.19 27/57] cxgb4: fix a memory leak bug Date: Sun, 8 Sep 2019 13:41:51 +0100 Message-Id: <20190908121136.425579987@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20190908121125.608195329@linuxfoundation.org> References: <20190908121125.608195329@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit c554336efa9bbc28d6ec14efbee3c7d63c61a34f ] In blocked_fl_write(), 't' is not deallocated if bitmap_parse_user() fails, leading to a memory leak bug. To fix this issue, free t before returning the error. Signed-off-by: Wenwen Wang Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c index 0f72f9c4ec74c..b429b726b987b 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c @@ -3276,8 +3276,10 @@ static ssize_t blocked_fl_write(struct file *filp, const char __user *ubuf, return -ENOMEM; err = bitmap_parse_user(ubuf, count, t, adap->sge.egr_sz); - if (err) + if (err) { + kvfree(t); return err; + } bitmap_copy(adap->sge.blocked_fl, t, adap->sge.egr_sz); kvfree(t); -- 2.20.1