From: "Valentin Vidić" <vvidic@valentin-vidic.from.hr>
To: "Valdis Klētnieks" <valdis.kletnieks@vt.edu>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] staging: exfat: drop unused field access_time_ms
Date: Mon, 9 Sep 2019 06:14:00 +0000 [thread overview]
Message-ID: <20190909061400.GI7664@valentin-vidic.from.hr> (raw)
In-Reply-To: <1049678.1567988361@turing-police>
On Sun, Sep 08, 2019 at 08:19:21PM -0400, Valdis Klētnieks wrote:
> In that case, rather than removing it, shouldn't we be *adding*
> code to properly set it instead?
Right, setting the UtcOffset fields to 0 is the first step marking
them as invalid for now. This is also why access_time_ms did not do
any harm here - it was always set to 0 too.
7.4.10.2 OffsetValid Field
The OffsetValid field shall describe whether the contents of the OffsetFromUtc
field are valid or not, as follows:
0, which means the contents of the OffsetFromUtc field are invalid
and shall be 00h
1, which means the contents of the OffsetFromUtc field are valid
--
Valentin
next prev parent reply other threads:[~2019-09-09 6:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-08 16:10 [PATCH v2 1/3] staging: exfat: drop duplicate date_time_t struct Valentin Vidic
2019-09-08 16:10 ` [PATCH v2 2/3] staging: exfat: drop unused field access_time_ms Valentin Vidic
2019-09-08 16:41 ` Greg Kroah-Hartman
2019-09-09 0:19 ` Valdis Klētnieks
2019-09-09 6:14 ` Valentin Vidić [this message]
2019-09-08 16:10 ` [PATCH v2 3/3] staging: exfat: add millisecond support Valentin Vidic
2019-09-08 16:40 ` Greg Kroah-Hartman
2019-09-08 16:51 ` Valentin Vidić
2019-09-08 16:45 ` [PATCH v2 1/3] staging: exfat: drop duplicate date_time_t struct Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190909061400.GI7664@valentin-vidic.from.hr \
--to=vvidic@valentin-vidic.from.hr \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=valdis.kletnieks@vt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).